8365543: UnixNativeDispatcher.init should lookup open64at and stat64at on AIX

[MBaesken]

Java_sun_nio_fs_UnixNativeDispatcher_init currently misses to set the correct OS functions for my_openat_func and my_fstatat_func on AIX ; this should be adjusted.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365543: UnixNativeDispatcher.init should lookup open64at and stat64at on AIX (Bug - P4)

Reviewers

• Joachim Kern (@JoKern65 - Committer)
• Thomas Stuefe (@tstuefe - Reviewer)
• Goetz Lindenmaier (@GoeLin - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Contributors

• Joachim Kern <jkern@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26793/head:pull/26793
$ git checkout pull/26793

Update a local copy of the PR:
$ git checkout pull/26793
$ git pull https://git.openjdk.org/jdk.git pull/26793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26793

View PR using the GUI difftool:
$ git pr show -t 26793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26793.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365543: UnixNativeDispatcher.init should lookup open64at and stat64at on AIX

Co-authored-by: Joachim Kern <jkern@openjdk.org>
Reviewed-by: jkern, stuefe, goetz, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• dbae90c: 8364723: Sort share/interpreter includes
• 059b49b: 8365244: Some test control variables are undocumented in doc/testing.md
• b6d5f49: 8365296: Build failure with Clang due to -Wformat warning after JDK-8364611
• ... and 3 more: https://git.openjdk.org/jdk/compare/6fb6f3d39b321e2a1c1fa2cef2c19222a6dcf7b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[MBaesken]

/help

[openjdk]

@MBaesken Available commands:

• approval - request for maintainer's approval
• approve - null
• author - sets an overriding author to be used in the commit when the PR is integrated
• backport - create a backport
• cc - add or remove an additional classification label
• clean - Mark the backport pull request as a clean backport
• contributor - adds or removes additional contributors for a PR
• covered - used when employer has signed the OCA
• csr - require a compatibility and specification request (CSR) for this pull request
• help - shows this text
• integrate - performs integration of the changes in the PR
• issue - edit the list of issues that this PR solves
• jep - require a JDK Enhancement Proposal (JEP) for this pull request
• keepalive - Re-evaluates the pull request and resets the inactivity timeout.
• label - add or remove an additional classification label
• open - Set the pull request state to "open"
• reviewer - manage additional reviewers for a PR
• reviewers - set the number of additional required reviewers for this PR
• signed - used after signing the OCA
• solves - edit the list of issues that this PR solves
• sponsor - performs integration of a PR that is authored by a non-committer
• summary - updates the summary in the commit message
• test - used to run tests
• touch - Re-evaluates the pull request and resets the inactivity timeout.

[MBaesken]

/contributor add jkern

[openjdk]

@MBaesken
Contributor Joachim Kern <jkern@openjdk.org> successfully added.

[mlbridge]

Webrevs

• 00: Full (720472de)

[JoKern65]

LGTM

[tstuefe]

+1

[GoeLin]

Impressive subtle difference in function names. Looks good.
Thanks for cleaning up the #ifdefs along with this.

[bplb]

Looks all right to me also, but I'll abstain from approving as it's AIX.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 166ea12.
Since your change was applied there have been 16 commits pushed to the master branch:

• e7ca8c7: 8365436: ImageReaderTest fails when jmods directory not present
• f364fca: 8359119: Change Charset to use StableValue
• bd65d48: 8365245: Move size reducing operations to GrowableArrayWithAllocator
• ... and 13 more: https://git.openjdk.org/jdk/compare/6fb6f3d39b321e2a1c1fa2cef2c19222a6dcf7b9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 166ea12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.