8365594: Strengthen Universe klasses asserts to catch bootstrapping errors earlier

[shipilev]

I am chasing a Shenandoah + CDS bootstrapping problem, where Shenandoah tries to insert the filler at the time when Universe is not yet initialized. It currently fails rather cryptically on attempt to store null class. We could really use an assert on accessing various Klass definitions in Universe.

We already do this for TypeArrayKlass-es, so this change would cover fillerArrayKlass and objectArrayKlass.

Additional testing:

• Shenandoah + CDS reproducer crashes reliably
• Linux AArch64 server fastdebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365594: Strengthen Universe klasses asserts to catch bootstrapping errors earlier (Enhancement - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26797/head:pull/26797
$ git checkout pull/26797

Update a local copy of the PR:
$ git checkout pull/26797
$ git pull https://git.openjdk.org/jdk.git pull/26797/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26797

View PR using the GUI difftool:
$ git pr show -t 26797

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26797.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365594: Strengthen Universe klasses asserts to catch bootstrapping errors earlier

Reviewed-by: coleenp, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• 81c6ed3: 8365533: Remove outdated jdk.internal.javac package export to several modules from java.base
• c1198bb: 8357277: Update OpenSSL library for interop tests
• a42ba1f: 8365638: JFR: Add --exact for debugging out-of-order events
• ... and 57 more: https://git.openjdk.org/jdk/compare/19a76a45e9c8616414830c865801660bc6761e92...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6aa2c75c)

[coleenp]

Looks good.

[shipilev]

Thank you, @coleenp! I think I need another Review to integrate.

[shipilev]

Thanks! Here goes.

/integrate

[openjdk]

Going to push as commit c9ecedd.
Since your change was applied there have been 61 commits pushed to the master branch:

• 2a16cc8: 8365550: JFR: The active-settings view should not use LAST_BATCH
• 81c6ed3: 8365533: Remove outdated jdk.internal.javac package export to several modules from java.base
• c1198bb: 8357277: Update OpenSSL library for interop tests
• ... and 58 more: https://git.openjdk.org/jdk/compare/19a76a45e9c8616414830c865801660bc6761e92...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit c9ecedd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.