8365425: [macos26] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java fails on macOS 26

[prsadhuk]

Test compares specific pixels with expected color and needed color profile setting in macOS26 is not available it seems.
Since the pixel color difference is slightly off, I have added a tolerance which had been present in many other tests so it's not without precedent

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365425: [macos26] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java fails on macOS 26 (Bug - P4)

Reviewers

• Damon Nguyen (@DamonGuy - Committer)
• Alexander Zuev (@azuev-java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26833/head:pull/26833
$ git checkout pull/26833

Update a local copy of the PR:
$ git checkout pull/26833
$ git pull https://git.openjdk.org/jdk.git pull/26833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26833

View PR using the GUI difftool:
$ git pr show -t 26833

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26833.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365425: [macos26] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java fails on macOS 26

Reviewed-by: dnguyen, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 160 new commits pushed to the master branch:

• cf70cb7: 8365024: G1: Make G1CollectionSet::_inc_build_state assert-only
• fb651fd: 8364638: Refactor and make accumulated GC CPU time code generic
• 1548ac4: 8365378: Redundant code in Deoptimization::print_statistics
• ... and 157 more: https://git.openjdk.org/jdk/compare/d0624f8b62fe0c70e5b6a47e05235ca65a2e1a13...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (4a57cb01)
• 01: Full - Incremental (0517747a)
• 00: Full (2c29e497)

[mrserb]

the test might be updated to render components into the buffered image and then compare exact values.

[DamonGuy]

The suggestion to use the components in the BufferedImage sounds fair.

The fix here does make the test pass consistently when testing on a macOS 26 device myself. I ran it multiple times with no failures, where the original test (without the changes) did fail consistently. LGTM.

[prsadhuk]

I modified the test to render component in to bufferedimage

[DamonGuy]

I tested the updated test with the rendered components on macOS 26. Same results as my last approval. Everything seems to be passing and LGTM when the test previously failed.

[azuev-java]

the test might be updated to render components into the buffered image and then compare exact values.

And what does it test then? The original bug was about dragging the internal frame creates artifacts on the underlying component. By drawing the component after the drag into the BufferedImage - are we sure the artifacts will be drawn there too? I have my doubts about the logic of the test after the last change...

[prsadhuk]

the test might be updated to render components into the buffered image and then compare exact values.

And what does it test then? The original bug was about dragging the internal frame creates artifacts on the underlying component. By drawing the component after the drag into the BufferedImage - are we sure the artifacts will be drawn there too? I have my doubts about the logic of the test after the last change...

I guess you are right..I am not able to get the artifacts drawn into the BI with this...With createScreenCapture I could get so I reverted to the tolerance check

[prsadhuk]

/integrate

[openjdk]

Going to push as commit bdf9834.
Since your change was applied there have been 161 commits pushed to the master branch:

• d757246: 8365891: failed: Completed task should not be in the queue
• cf70cb7: 8365024: G1: Make G1CollectionSet::_inc_build_state assert-only
• fb651fd: 8364638: Refactor and make accumulated GC CPU time code generic
• ... and 158 more: https://git.openjdk.org/jdk/compare/d0624f8b62fe0c70e5b6a47e05235ca65a2e1a13...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit bdf9834.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mrserb]

I guess you are right..I am not able to get the artifacts drawn into the BI with this...With createScreenCapture I could get so I reverted to the tolerance check

That because you have to set float transform for that rendering, to reproduce the artifacts, for screen it is covered by the Dsun.java2d.uiScale in the header of the test. There is no difference between rendering to the screen vs rendering to BI.

[prsadhuk]

I guess you are right..I am not able to get the artifacts drawn into the BI with this...With createScreenCapture I could get so I reverted to the tolerance check

That because you have to set float transform for that rendering, to reproduce the artifacts, for screen it is covered by the Dsun.java2d.uiScale in the header of the test. There is no difference between rendering to the screen vs rendering to BI.

How specifically could you suggest for my future reference?