-
Notifications
You must be signed in to change notification settings - Fork 5.8k
JDK-8262163: Extend settings printout in jcmd VM.metaspace #2686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8262163: Extend settings printout in jcmd VM.metaspace #2686
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
Looks good! IMHO, can we simply reorder these settings? i.e. Settings: |
Hi Yang,
Sure, I can reorder that, but on what base? Alphabetically? ..Thomas |
Maybe good-looking based ordering : ) |
In that case I rather keep it as it is, since its ordered by subjective importance :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
What I don't like is the printout of the MaxMetaspaceSize value. It is outrageously big. The value displayed corresponds to 0x400000000 GB. Looking at the code, I would expect "unlimited" to be printed. Can you explain why it is not?
I just found JDK-8262099. It deals with the effect I disliked in my review comment. So, once JDK-8262099 is in, I am happy with this change here. |
Thanks Lutz! Yes, I left the fix for MaxMetaspaceSize out to not interfere with Yi Yang's change. Cheers, Thomas |
/integrate |
@tstuefe This PR has not yet been marked as ready for integration. |
@RealLucy Can you please approve then? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the other change: LGTM.
@RealLucy Can you please approve? As in, press the "Approve" button? :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@tstuefe Since your change was applied there have been 28 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit ea48a0b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is quite trivial.
jcmd VM.metaspace prints metaspace settings at the end of its printout. Missing from that printout are some settings which would be nice to see here, eg the GC thresholds and CDS settings (nice to know since CDS affects how metaspace is used).
Example output:
Tests: Manually ran runtime/Metaspace/PrintMetaspaceDcmd.java.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2686/head:pull/2686
$ git checkout pull/2686