8360160: ubuntu-22-04 machine is failing client tests #26871
Conversation
|
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
added
client
Webrevs
|
| robot.delay(1000); | ||
| System.out.println("frames.length: "+frames.length); | ||
|
|
||
| System.out.println("frames.length: " + frames.length); |
There was a problem hiding this comment.
I suspect that the root cause of this failure is the same as in the JDK-8280987 - spawning a log of windows at once, like one or two hundred. This is still happening with the updated test in the createAndShowUI().
I guess they should either be shown in batches (of 20 windows, for example) with a delay between each batch to give the system time to handle them or the number of tested graphics configurations should be reduced.
There was a problem hiding this comment.
I see I misunderstood slightly from when you previously brought this up. Thanks for the info! I can do this in batches and show these side by side instead.
I was able to recreate the failure now in ubuntu 22.04 and it crashes with 210 open windows at once (due to having many gcs detected). I'll update this PR with this change next.
| d = frames[index].getSize(); | ||
| }); | ||
| Rectangle rect = new Rectangle(p, d); | ||
| BufferedImage img = robot.createScreenCapture(rect); |
There was a problem hiding this comment.
I am not sure if the current and previous implementations of the test are really helpful.
Note the very dark window shadow in the screenshot of the PR description. These are the overlapping shadows of multiple windows placed on top of each other.
It seems that at the time of writing, the test expected that the system would arrange the windows next to each other, but this is no longer the case.
In the test, we try to get the same bounds for each window because they are stacked on top of each other. However, this means that we only check the top window multiple times, which is not useful.
I think we should place the windows across the entire screen and take a screenshot of each one. Considering there may be many windows, this may need to be done in several batches.
|
@DamonGuy This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
4 participants
Ubuntu machine has multiple failing java awt tests. When looking at the screenshots of the desktop when each test fails, a white square can be seen at the top-left of the desktop.
This seems to be similar to the white square that
FrameVisualTest.javacreates so the frame was not disposed of properly during this failure. I have tried re-creating this failure on Ubuntu 22.04, similar to the failure OS that this originally occurred on, to no avail. I ran this test individually, and with all of the listed failing tests back-to-back but all the tests pass as normal. This stabilization fix to the test attempts to prevent this in case it occurs again.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26871/head:pull/26871$ git checkout pull/26871Update a local copy of the PR:
$ git checkout pull/26871$ git pull https://git.openjdk.org/jdk.git pull/26871/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26871View PR using the GUI difftool:
$ git pr show -t 26871Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26871.diff
Using Webrev
Link to Webrev Comment