8361610: Avoid wasted work in ImageIcon(Image) for setting description

[prsadhuk]

The ImageIcon(Image) constructor sets the description field to the value of "comment" property if it's a string. The ImageIcon(Image, String) constructor calls ImageIcon(Image). Since the two-parameter constructor explicitly provides the value for the description field, the implicitly set value for description is immediately overwritten, which is wasted work.

Fix is to let ImageIcon(Image, String) constructor do the actual work of setting the fields and loading the image

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361610: Avoid wasted work in ImageIcon(Image) for setting description (Bug - P4)

Reviewers

• Alexander Zuev (@azuev-java - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26873/head:pull/26873
$ git checkout pull/26873

Update a local copy of the PR:
$ git checkout pull/26873
$ git pull https://git.openjdk.org/jdk.git pull/26873/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26873

View PR using the GUI difftool:
$ git pr show -t 26873

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26873.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361610: Avoid wasted work in ImageIcon(Image) for setting description

Reviewed-by: kizune, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 189 new commits pushed to the master branch:

• 5cc8673: 8365765: thread.inline.hpp includes the wrong primary header file
• 57434c7: 8365976: G1: Full gc should mark nmethods on stack
• 28bd29f: 8365034: G1: Remove num_groups_selected in G1CollectionSet::select_candidates_from_optional_groups as it is unnecessary
• ... and 186 more: https://git.openjdk.org/jdk/compare/d0624f8b62fe0c70e5b6a47e05235ca65a2e1a13...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8044562e)

[azuev-java]

LGTM

[prsadhuk]

/integrate

[openjdk]

Going to push as commit e507766.
Since your change was applied there have been 196 commits pushed to the master branch:

• 21efd25: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block
• a629424: 8365579: ml64.exe is not the right assembler for Windows aarch64
• 1a7ac16: 8364382: Remove sun/tools/jstat/jstatLineCountsX.sh from ProblemList on linux-ppc64le and aix due to JDK-8248691
• ... and 193 more: https://git.openjdk.org/jdk/compare/d0624f8b62fe0c70e5b6a47e05235ca65a2e1a13...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit e507766.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.