Skip to content

Conversation

@mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Aug 21, 2025

I broke the build by integrating #26023 so backing it out with this PR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365910: [BACKOUT] Add a compilation timeout flag to catch long running compilations (Sub-task - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26874/head:pull/26874
$ git checkout pull/26874

Update a local copy of the PR:
$ git checkout pull/26874
$ git pull https://git.openjdk.org/jdk.git pull/26874/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26874

View PR using the GUI difftool:
$ git pr show -t 26874

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26874.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2025

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365910: [BACKOUT] Add a compilation timeout flag to catch long running compilations

Reviewed-by: chagedorn, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a7c0f4b: 8365146: Remove LockingMode related code from ppc64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@mhaessig The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review labels Aug 21, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2025

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial, thanks for taking care of that!

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backout looks good. Thanks for the quick response.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 21, 2025
@mhaessig
Copy link
Contributor Author

Thank you for your reviews and sorry for the noise.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

Going to push as commit 5febc4e.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a7c0f4b: 8365146: Remove LockingMode related code from ppc64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2025
@openjdk openjdk bot closed this Aug 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2025
@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@mhaessig Pushed as commit 5febc4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants