8366002: Beans.instantiate needs to describe the lookup procedure #26905
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 574 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
openjdk
bot
changed the title
openjdk
bot
added
client
Webrevs
|
prrace
changed the title
|
Do we have any tests that verify it actually works as described in the updated specification? |
If you didn't see any, there probably aren't. |
aivanov-jdk
left a comment
aivanov-jdk
left a comment
There was a problem hiding this comment.
I see you just restoring the relevant portions of the existing javadoc for a removed method. Marking up can be postponed to a later time, if at all.
|
@prrace This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
prrace
left a comment
prrace
left a comment
There was a problem hiding this comment.
I've updated this with a couple of suggestions, including one from CSR review to link to a definition of binary name.
aivanov-jdk
left a comment
aivanov-jdk
left a comment
There was a problem hiding this comment.
Looks good to me, however, I think it could be improved with marking up example class names and file names with {@code}.
| * Instantiate a JavaBean. | ||
| * </p> | ||
| * The bean is created based on a name relative to a class-loader. | ||
| * This name should be a {@linkplain ClassLoader##binary-name binary name} of a class such as "a.b.C". |
There was a problem hiding this comment.
| * This name should be a {@linkplain ClassLoader##binary-name binary name} of a class such as "a.b.C". | |
| * This name should be a {@linkplain ClassLoader##binary-name binary name} | |
| * of a class such as "a.b.C". |
Shall we wrap this line?
Should the names in the quotes be marked up with {@code} too?
| * For example, given a {@code beanName} of "x.y", {@code Beans.instantiate} would first | ||
| * try to read a serialized object from the resource "x/y.ser" and if | ||
| * that failed it would try to load the class "x.y" and create an | ||
| * instance of that class. |
There was a problem hiding this comment.
| * For example, given a {@code beanName} of "x.y", {@code Beans.instantiate} would first | |
| * try to read a serialized object from the resource "x/y.ser" and if | |
| * that failed it would try to load the class "x.y" and create an | |
| * instance of that class. | |
| * For example, given a {@code beanName} of {@code "x.y"}, {@code Beans.instantiate} would first | |
| * try to read a serialized object from the resource {@code "x/y.ser"} and if | |
| * that failed it would try to load the class {@code "x.y"} and create an | |
| * instance of that class. |
I think the example names of the classes and files should be marked up with {@code}. This also applies to ".ser" in the paragraph above.
There was a problem hiding this comment.
I'm not sure that is necessary.
There was a problem hiding this comment.
Should the copyright year be bumped to 2025?
openjdk
bot
added
ready
|
/integrate |
|
Going to push as commit 6bfd018.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
3 participants
Some text describing the Beans.instantiate lookup process existed only on the method that used the now removed AppletInitializer.
Since there are two other Beans.instantiate methods, we need to move that text to the remaining methods.
Note that one of the methods is also deprecated for removal, so it seems prudent to add it to both so that when the next to be removed method is gone, this problem doesn't recur.
This is a doc. only change. The CSR is ready for review.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26905/head:pull/26905$ git checkout pull/26905Update a local copy of the PR:
$ git checkout pull/26905$ git pull https://git.openjdk.org/jdk.git pull/26905/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26905View PR using the GUI difftool:
$ git pr show -t 26905Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26905.diff
Using Webrev
Link to Webrev Comment