-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8246037: Shenandoah: update man pages to mention -XX:+UseShenandoahGC #26907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
66b9981
8246037: Shenandoah: update man pages to mention -XX:+UseShenandoahGC
rgithubli a9d1f6a
Comment for aggressive. Indent.
rgithubli 1875874
Update for comments
rgithubli b319e2b
gen shen and heuristics
rgithubli cbf1819
Add shen hpp changes
rgithubli 1c8d334
shen hpp changes
rgithubli 1c25fbb
update for threshold wording
rgithubli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
ShenandoahMinFreeThresholdis experimental, it is not worth mentioning here. In fact, there are tunables foradaptiveandcompactas well, yet we do not (correctly!) mention them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, other options respond to
ShenandoahMinFreeThresholdas well. It's kinda hard to describestaticoption without mentioning the threshold.trigger GC when free heap falls below the threshold.staticis a non experimental flag - it has to be used with other experimental flags. Maybe just drop static from man page as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
below a specified thresholdmight sound appropriately vague and render the flag unusable unless one consulted the code, underlining the experimental nature of it.If the collector respects
staticas specified, it can be considered a good guardrail to use in anger. In fact, I know of teams that do in production. (For that matter, there are a couple who usecompactas well.)However, I am fine with eliding all experimental options, and in turn any non-experimental options that depend on experimental options (which however seems to be an anti-pattern to be avoided, if possible).