8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

[myankelev]

Skipped tests are treated as a pass:

• test/jdk/sun/security/pkcs11/KeyStore/ClientAuth.java
• test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java
• test/jdk/sun/security/pkcs11/SecretKeyFactory/TestGeneral.java
• test/jdk/sun/security/pkcs11/SecureRandom/Basic.java
• test/jdk/sun/security/pkcs11/SecureRandom/TestDeserialization.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom (Bug - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26942/head:pull/26942
$ git checkout pull/26942

Update a local copy of the PR:
$ git checkout pull/26942
$ git pull https://git.openjdk.org/jdk.git pull/26942/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26942

View PR using the GUI difftool:
$ git pr show -t 26942

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26942.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 365 new commits pushed to the master branch:

• bcff857: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8
• 03c54d4: 8365689: Elements.getFileObjectOf fails with a NullPointerException when an erroneous Element is passed in
• a272696: 8365190: Remove LockingMode related code from share
• ... and 362 more: https://git.openjdk.org/jdk/compare/0ad919c1e54895b000b58f6a1b54d79f76970845...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@myankelev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (7a16f494)
• 02: Full - Incremental (b9d3f123)
• 01: Full - Incremental (867b81d3)
• 00: Full (ed4c20a2)

[wangweij]

The original test runs all cases but the updated would stop once any of them is skipped. Is this intended?

Also, I cannot see a benefit to rethrow a SkippedException with only a modified message. Why not just let it bubble up?

[myankelev]

Thank you for noticing, this is definitely not intentional. It should show this error only if there are some tests skipped, but should still run all of them. This way the error will not be hidden by the skip in another test.

This is also why I didn't bubble it up, as this was not supposed to be triggered until all the tests are finished.

This should be fixed in the next commit

[myankelev]

/integrate

[openjdk]

@myankelev
Your change (at version 7a16f49) is now ready to be sponsored by a Committer.

[wangweij]

/sponsor

[openjdk]

Going to push as commit 166ef5e.
Since your change was applied there have been 365 commits pushed to the master branch:

• bcff857: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8
• 03c54d4: 8365689: Elements.getFileObjectOf fails with a NullPointerException when an erroneous Element is passed in
• a272696: 8365190: Remove LockingMode related code from share
• ... and 362 more: https://git.openjdk.org/jdk/compare/0ad919c1e54895b000b58f6a1b54d79f76970845...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij @myankelev Pushed as commit 166ef5e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.