8366255: Remove 'package_to_module' function from imageFile.cpp

[david-beaumont]

Removing the 'package_to_module' function from imageFile.cpp and the associated JNI export.
This code isn't used or referenced from anywhere, and removing it makes adapting the package flags for use with preview mode simpler.

A clone of the Valhalla PR:
openjdk/valhalla#1535

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366255: Remove 'package_to_module' function from imageFile.cpp (Sub-task - P4)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26965/head:pull/26965
$ git checkout pull/26965

Update a local copy of the PR:
$ git checkout pull/26965
$ git pull https://git.openjdk.org/jdk.git pull/26965/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26965

View PR using the GUI difftool:
$ git pr show -t 26965

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26965.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@david-beaumont This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366255: Remove 'package_to_module' function from imageFile.cpp

Reviewed-by: rriggs, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 415 new commits pushed to the master branch:

• 075ddef: 8364039: Adding implNote to DOMSignContext and DOMValidateContext on JDK-specific properties
• bd4c0f4: 8358618: UnsupportedOperationException constructors javadoc is not clear
• f1c0b4e: 8361495: (fc) Async close of streams connected to uninterruptible FileChannel doesn't throw AsynchronousCloseException in all cases
• ... and 412 more: https://git.openjdk.org/jdk/compare/743c821289a6562972364b5dcce8dd29a786264a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @coleenp) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@david-beaumont To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• net
• nio
• security
• serviceability
• shenandoah

[coleenp]

/label core-libs

[openjdk]

@coleenp
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 00: Full (7d92134a)

[RogerRiggs]

Look good, thanks for up-streaming this cleanup.

[AlanBateman]

/label add hotspot-runtime

[openjdk]

@AlanBateman
The hotspot-runtime label was successfully added.

[coleenp]

It's not really hotspot-runtime code unless @dholmes-ora knows anything about it.

[AlanBateman]

It's not really hotspot-runtime code unless @dholmes-ora knows anything about it.

Change to libjimage usually need eyes from both core-libs and hotspot-runtime, the latter due to the usage in classLoader.cpp.

[david-beaumont]

/integrate

[openjdk]

@david-beaumont
Your change (at version 7d92134) is now ready to be sponsored by a Committer.

[dholmes-ora]

Nothing runtime affecting that I can see and no changes to hotspot code so no 24 hour rule.

Changes look fine.

/sponsor

[openjdk]

Going to push as commit ab1f2af.
Since your change was applied there have been 418 commits pushed to the master branch:

• 57df267: 8365262: [IR-Framework] Add simple way to add cross-product of flags
• 443b172: 8324751: C2 SuperWord: Aliasing Analysis runtime check
• 501e6ae: 8366223: ZGC: ZPageAllocator::cleanup_failed_commit_multi_partition is broken
• ... and 415 more: https://git.openjdk.org/jdk/compare/743c821289a6562972364b5dcce8dd29a786264a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora @david-beaumont Pushed as commit ab1f2af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.