8366342: Key generator and key pair generator tests skipping, but showing as passed

[myankelev]

• Minor cleanup
• Key generator and key pair generator tests skipping, but showing as passed:
  • test/jdk/sun/security/pkcs11/KeyGenerator/DESParity.java
  • test/jdk/sun/security/pkcs11/KeyGenerator/TestAES.java
  • test/jdk/sun/security/pkcs11/KeyGenerator/TestChaCha20.java
  • test/jdk/sun/security/pkcs11/KeyGenerator/TestKeyGenerator.java
  • test/jdk/sun/security/pkcs11/KeyPairGenerator/TestDH2048.java
  • test/jdk/sun/security/pkcs11/KeyPairGenerator/TestDefaultDHPrivateExpSize.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366342: Key generator and key pair generator tests skipping, but showing as passed (Bug - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26985/head:pull/26985
$ git checkout pull/26985

Update a local copy of the PR:
$ git checkout pull/26985
$ git pull https://git.openjdk.org/jdk.git pull/26985/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26985

View PR using the GUI difftool:
$ git pr show -t 26985

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26985.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366342: Key generator and key pair generator tests skipping, but showing as passed

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 237 new commits pushed to the master branch:

• 86d6a2e: 8366147: ZGC: ZPageAllocator::cleanup_failed_commit_single_partition may leak memory
• a2da75a: 8362884: [GCC static analyzer] unix NetworkInterface.c addif leak on early returns
• b8cdf31: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved
• ... and 234 more: https://git.openjdk.org/jdk/compare/0ad919c1e54895b000b58f6a1b54d79f76970845...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@myankelev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2e004c9b)

[wangweij]

Looks good. Why are these included in the previous PR?

[myankelev]

Looks good. Why are these included in the previous PR?

Grouping tests by folder as detecting them

[myankelev]

/integrate

[openjdk]

@myankelev
Your change (at version 2e004c9) is now ready to be sponsored by a Committer.

[myankelev]

/sponsor

[openjdk]

@myankelev This change does not need sponsoring - the author is allowed to integrate it.

[myankelev]

/integrate

[openjdk]

Going to push as commit 7690a45.
Since your change was applied there have been 425 commits pushed to the master branch:

• 2826d17: 8367243: Format issues with dist dump debug output in PhaseGVN::dead_loop_check
• 4cc75be: 8366702: C2 SuperWord: refactor VTransform vector nodes
• eb9e045: 8361530: Test javax/swing/GraphicsConfigNotifier/StalePreferredSize.java timed out
• ... and 422 more: https://git.openjdk.org/jdk/compare/0ad919c1e54895b000b58f6a1b54d79f76970845...master

Your commit was automatically rebased without conflicts.

[openjdk]

@myankelev Pushed as commit 7690a45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.