Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 28, 2025

Recent versions of GCC have a static code analyzer option (-fanalyzer) that works quite well for C code (but it has still issues with C++).
This can be used to identify e.g. some leaks like memory leaks, double close, use of uninitialized data etc. .
Some info about it :

https://gcc.gnu.org/onlinedocs/gcc/Static-Analyzer-Options.html
https://developers.redhat.com/articles/2023/05/31/improvements-static-analysis-gcc-13-compiler


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362516: Support of GCC static analyzer (-fanalyzer) (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26989/head:pull/26989
$ git checkout pull/26989

Update a local copy of the PR:
$ git checkout pull/26989
$ git pull https://git.openjdk.org/jdk.git pull/26989/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26989

View PR using the GUI difftool:
$ git pr show -t 26989

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26989.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362516: Support of GCC static analyzer (-fanalyzer)

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8362516: Support of GCC static analyzer (-fanalyzer) 8362516: Support of GCC static analyzer (-fanalyzer) Aug 28, 2025
@MBaesken
Copy link
Member Author

Usage is --enable-static-analyzer --disable-warnings-as-errors (if warnings as errors are not disabled, we ru n into warnings generated by the analyzer).

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org rfr Pull request is ready for review labels Aug 28, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 28, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 29, 2025
@MBaesken
Copy link
Member Author

MBaesken commented Sep 1, 2025

Hi Erik, thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

Going to push as commit ba90ccc.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2025
@openjdk openjdk bot closed this Sep 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2025
@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@MBaesken Pushed as commit ba90ccc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants