8361593: Commented dead code in JDK-8342868 can be removed

[fandreuz]

JDK-8342868 commented out code rather than removing it. The code can be removed safely, as pointed out in the PR review: #21654.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361593: Commented dead code in JDK-8342868 can be removed (Enhancement - P4)

Reviewers

• Justin Lu (@justin-curtis-lu - Committer)
• Naoto Sato (@naotoj - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27012/head:pull/27012
$ git checkout pull/27012

Update a local copy of the PR:
$ git checkout pull/27012
$ git pull https://git.openjdk.org/jdk.git pull/27012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27012

View PR using the GUI difftool:
$ git pr show -t 27012

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27012.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361593: Commented dead code in JDK-8342868 can be removed

Reviewed-by: jlu, naoto, jwaters, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• f23c150: 8366359: Test should throw SkippedException when there is no lpstat
• d4ce630: 8366399: Allow custom base reference for update_copyright_year.sh

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@justin-curtis-lu, @naotoj, @TheShermanTanker, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fandreuz The following labels will be automatically applied to this pull request:

• core-libs
• i18n
• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (09067914)

[justin-curtis-lu]

Removals are consistent with the ones commented out in #21654.

[naotoj]

LGTM

[fandreuz]

/integrate

[openjdk]

@fandreuz
Your change (at version 0906791) is now ready to be sponsored by a Committer.

[TheShermanTanker]

Test failure is because JDK source failed to check out rather than anything related to this change

[jaikiran]

Looks OK to me.

[jaikiran]

/sponsor

[openjdk]

Going to push as commit 9339a6a.
Since your change was applied there have been 4 commits pushed to the master branch:

• 12e6a0b: 8366208: Unexpected exception in sun.java2d.cmm.lcms.LCMSImageLayout
• 0e73993: 8366264: tools/javac/launcher/SourceLauncherStackTraceTest.java does not cover the scenario for 8362237
• f23c150: 8366359: Test should throw SkippedException when there is no lpstat
• ... and 1 more: https://git.openjdk.org/jdk/compare/849570a94a3178da7899e5cd36400ef03ad9ae29...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @fandreuz Pushed as commit 9339a6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.