8366400: JCK test api/java_text/DecimalFormat/Parse.html fails after JDK-8363972 #27014

justin-curtis-lu · 2025-08-29T23:59:54Z

This PR addresses a JCK test failure of an unexpected SIOOBE during DecimalFormat parsing. During the char by char comparison in matchAffix, the minimum of the length of the parsed String and the PP index + affix length are iterated on. The parse position index needs to be checked to not be negative to ensure that we do not index the String below 0. Taking the minimum of those two previously mentioned values already guarantees that we do not index the String above the length.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8366400: JCK test api/java_text/DecimalFormat/Parse.html fails after JDK-8363972 (Bug - P2)

Reviewers

Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27014/head:pull/27014
$ git checkout pull/27014

Update a local copy of the PR:
$ git checkout pull/27014
$ git pull https://git.openjdk.org/jdk.git pull/27014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27014

View PR using the GUI difftool:
$ git pr show -t 27014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27014.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-08-30T00:00:58Z

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-08-30T00:01:36Z

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366400: JCK test api/java_text/DecimalFormat/Parse.html fails after JDK-8363972

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

991ac9e: 8365407: Race condition in MethodTrainingData::verify()
80fb708: 8365175: Replace Unicode extension anchor elements with link tag
0d85f07: 8359174: tools/jlink/JLink20000Packages.java timed out
... and 49 more: https://git.openjdk.org/jdk/compare/d594ef3a3e013b84a392b6d64a54015adc8173cd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-08-30T00:02:19Z

@justin-curtis-lu The following labels will be automatically applied to this pull request:

core-libs
i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-08-30T00:06:17Z

Webrevs

01: Full - Incremental (96f71a0f)
00: Full (79b57021)

AlanBateman · 2025-08-30T06:47:15Z

Would it be possible to review the DecimalFormat tests in the jdk repo? I'm wondering if the changes for lenient parsing in JDK-8363972 should have had more tests (it's good that tests elsewhere found the issue but it does suggest that we don't have enough tests in the jdk repo).

naotoj · 2025-09-02T17:01:58Z

test/jdk/java/text/Format/NumberFormat/LenientParseTest.java

+    @Test // Non-localized, only run once
+    @EnabledIfSystemProperty(named = "user.language", matches = "en")
+    public void invalidPositionParseTest() {
+        // -1 index should fail properly. Ensure SIOOBE not thrown during
+        // affix matching when position may be less than 0
+        assertNull(assertDoesNotThrow(() -> new DecimalFormat().parse("1", new ParsePosition(-1))));
+    }
+


Thanks for writing the invalid case test. As Alan suggested, maybe we could provide more edge case tests.

Added some additional tests with a focus on affix matching, specifically ensuring SIOOBE does not leak out in any of those cases. i.e. The bounds checks should ensure false is returned for those cases. But specifically for the failing JCK test, the main test we need on the JDK repo side is a negative ParsePosition index test.

naotoj

LGTM. Moving position tests unrelated to lenient minus parsing to here is good.

naotoj · 2025-09-02T22:45:35Z

test/jdk/java/text/Format/NumberFormat/PositionTest.java

+    // Parsing text which contains un-parseable data, but the index
+    // begins at the valid portion. Ensure PP is properly updated.
+    @Test
+    public void modifiedPositionTest() {


JUnit5 tests default to package-private visibility, but I think aligning with other tests is more important.

AlanBateman · 2025-09-03T11:34:52Z

Thanks for expanding the coverage of the existing tests. That will help catch any regressions when changing the parsing code in the future.

justin-curtis-lu · 2025-09-03T21:57:13Z

/integrate

openjdk · 2025-09-03T21:58:29Z

Going to push as commit becc35f.
Since your change was applied there have been 66 commits pushed to the master branch:

431f467: 8361635: Missing List length validation in the Class-File API
8d23661: 8366155: Serial: Obsolete PretenureSizeThreshold
e3b36e3: 8366401: JCK test api/java_text/DecimalFormatSymbols/serial/InputTests.html fails after JDK-8363972
... and 63 more: https://git.openjdk.org/jdk/compare/d594ef3a3e013b84a392b6d64a54015adc8173cd...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-09-03T21:58:36Z

@justin-curtis-lu Pushed as commit becc35f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

justin-curtis-lu added 2 commits August 29, 2025 14:09

init

c02bd39

Add reg test

79b5702

openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org rfr Pull request is ready for review labels Aug 30, 2025

naotoj reviewed Sep 2, 2025

View reviewed changes

justin-curtis-lu added 2 commits September 2, 2025 15:08

Adding additional tests and moving tests to PositionTest

506e57e

Missing the bug ID in the new test

96f71a0

naotoj approved these changes Sep 2, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 2, 2025

openjdk bot added the integrated Pull request has been integrated label Sep 3, 2025

openjdk bot closed this Sep 3, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 3, 2025

8366400: JCK test api/java_text/DecimalFormat/Parse.html fails after JDK-8363972 #27014

8366400: JCK test api/java_text/DecimalFormat/Parse.html fails after JDK-8363972 #27014

Uh oh!

Conversation

justin-curtis-lu commented Aug 29, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Aug 30, 2025

Uh oh!

openjdk bot commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Aug 30, 2025

Uh oh!

mlbridge bot commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

AlanBateman commented Aug 30, 2025

Uh oh!

naotoj Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naotoj left a comment

Choose a reason for hiding this comment

Uh oh!

naotoj Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

AlanBateman commented Sep 3, 2025

Uh oh!

justin-curtis-lu commented Sep 3, 2025

Uh oh!

openjdk bot commented Sep 3, 2025

Uh oh!

openjdk bot commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

justin-curtis-lu commented Aug 29, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Aug 30, 2025 •

edited

Loading

mlbridge bot commented Aug 30, 2025 •

edited

Loading

justin-curtis-lu Sep 2, 2025 •

edited

Loading