Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8262269: javadoc test TestGeneratedClasses.java fails on Windows #2702

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Feb 24, 2021

Fix test to work on Windows.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262269: javadoc test TestGeneratedClasses.java fails on Windows

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2702/head:pull/2702
$ git checkout pull/2702

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 24, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 24, 2021
@openjdk
Copy link

openjdk bot commented Feb 24, 2021

@jonathan-gibbons The following labels will be automatically applied to this pull request:

  • compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org compiler compiler-dev@openjdk.org labels Feb 24, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 24, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 24, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262269: javadoc test TestGeneratedClasses.java fails on Windows

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3e13b66: 8262157: LingeredApp.startAppExactJvmOpts does not print app output when launching fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 24, 2021
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Feb 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 24, 2021
@openjdk
Copy link

openjdk bot commented Feb 24, 2021

@jonathan-gibbons Since your change was applied there has been 1 commit pushed to the master branch:

  • 3e13b66: 8262157: LingeredApp.startAppExactJvmOpts does not print app output when launching fails

Your commit was automatically rebased without conflicts.

Pushed as commit fac37bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the testGeneratedClasses branch February 24, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants