8351260: java.lang.AssertionError: Unexpected type tree: (ERROR) = (ERROR)

[lahodaj]

Consider a very broken declaration like this:

void test(List<@AlphaChars <@StringLength(int value = 5)String> s){ 

after seeing @AlphaChars, javac will try to parse <@StringLength(int value = 5)String> as a type, and assign the annotation to the type. But, the text does not parse as a type well (partly due to the int value = 5), and the parsing will proceed in an expression mode. Then a search for target type is performed to attach the annotation, and that fails, as the expression tree is not expected to be part of the type.

The main proposal here is to wrap the badly parsed type in an Erroneous tree. The overall error recovery then seems to handle the situation well.

The situation produces quite a few error reports, but it is not clear if this situation (esp. the nested int value = 5) is common enough to stretch the parsing error recovery capabilities to accommodate this code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351260: java.lang.AssertionError: Unexpected type tree: (ERROR) = (ERROR) (Bug - P3)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27065/head:pull/27065
$ git checkout pull/27065

Update a local copy of the PR:
$ git checkout pull/27065
$ git pull https://git.openjdk.org/jdk.git pull/27065/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27065

View PR using the GUI difftool:
$ git pr show -t 27065

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27065.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351260: java.lang.AssertionError: Unexpected type tree: (ERROR) = (ERROR)

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

• 5810707: 8366102: Clarification Needed: Symbolic Link Handling in File API Specifications
• 945aaf8: 8366897: RBTreeTest.IntrusiveCustomVerifyTest and RBTreeTest.CustomVerify tests fail on non-debug builds
• 1dc1d56: 8363858: [perf] OptimizeFill may use wide set of intrinsics
• ... and 59 more: https://git.openjdk.org/jdk/compare/99223eea03e2ed714f7a5408c356fdf06efc9200...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7935bcbc)

[vicente-romero-oracle]

lgtm

[lahodaj]

/integrate

[openjdk]

Going to push as commit f9dc640.
Since your change was applied there have been 88 commits pushed to the master branch:

• b0ca9bf: 8365776: Convert JShell tests to use JUnit instead of TestNG
• 8a6b875: 8354871: Replace stack map frame type magics with constants
• 14a40fd: 8361533: Apply java.io.Serial annotations in java.logging
• ... and 85 more: https://git.openjdk.org/jdk/compare/99223eea03e2ed714f7a5408c356fdf06efc9200...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit f9dc640.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.