8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64#27104
8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64#27104shipilev wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
It looks like GH is using a fleet of Reliant Robins as the runners for macOS arm64. Do you know what value of JTREG_JOBS is used for jtreg --concurrency on these apparently 3-core VMs? If concurrency is >1 then I assume we have more than one stress test running concurrently. (The change are okay of course. Right now, the TL handshake for virtual threads is limited to JVMTI usages but that make change, in which case we can re-visit Thread::getStackTrace and avoid the retry during transitions, and reduce the need for the GetStackTraceALotXXX stress tests). |
|
|
Seeing these tests failing often now. I think I need a second reviewer to integrate this, to make testing cleaner. |
One Reviewer is okay here. |
|
OK, thanks, here goes. /integrate |
|
Going to push as commit 0dad3f1.
Your commit was automatically rebased without conflicts. |
GetStackTraceALotWhenPinned test times out every so often in GHA.
The last sightings are on macos-aarch64:
Looks like we are nearly there, just need fewer iterations. I think like with JDK-8344577, we just need to extend the test check for AArch64 macs as well.
Additional testing:
java/lang/Thread/virtual/stress, 10xProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27104/head:pull/27104$ git checkout pull/27104Update a local copy of the PR:
$ git checkout pull/27104$ git pull https://git.openjdk.org/jdk.git pull/27104/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27104View PR using the GUI difftool:
$ git pr show -t 27104Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27104.diff
Using Webrev
Link to Webrev Comment