Skip to content

8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64#27104

Closed
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8366893-macos-slow-vttest
Closed

8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64#27104
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8366893-macos-slow-vttest

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Sep 4, 2025

GetStackTraceALotWhenPinned test times out every so often in GHA.

The last sightings are on macos-aarch64:

2025-09-04T10:41:29.357879Z => 87894 of 100000
2025-09-04T10:41:30.365534Z => 88105 of 100000
Timeout signalled after 300 seconds
2025-09-04T10:41:31.367068Z => 88298 of 100000
2025-09-04T10:41:32.377128Z => 88400 of 100000

2025-09-03T10:08:37.713537Z => 74715 of 100000
2025-09-03T10:08:38.717750Z => 74818 of 100000
Timeout signalled after 300 seconds
2025-09-03T10:08:39.722960Z => 74922 of 100000
2025-09-03T10:08:40.726642Z => 75024 of 100000

Looks like we are nearly there, just need fewer iterations. I think like with JDK-8344577, we just need to extend the test check for AArch64 macs as well.

Additional testing:

  • MacOS AArch64 server fastdebug, java/lang/Thread/virtual/stress, 10x

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27104/head:pull/27104
$ git checkout pull/27104

Update a local copy of the PR:
$ git checkout pull/27104
$ git pull https://git.openjdk.org/jdk.git pull/27104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27104

View PR using the GUI difftool:
$ git pr show -t 27104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27104.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64

Reviewed-by: alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

@shipilev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 4, 2025
@shipilev shipilev marked this pull request as ready for review September 4, 2025 18:43
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 4, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 4, 2025

Webrevs

@AlanBateman
Copy link
Contributor

It looks like GH is using a fleet of Reliant Robins as the runners for macOS arm64. Do you know what value of JTREG_JOBS is used for jtreg --concurrency on these apparently 3-core VMs? If concurrency is >1 then I assume we have more than one stress test running concurrently.

(The change are okay of course. Right now, the TL handshake for virtual threads is limited to JVMTI usages but that make change, in which case we can re-visit Thread::getStackTrace and avoid the retry during transitions, and reduce the need for the GetStackTraceALotXXX stress tests).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 5, 2025
@shipilev
Copy link
Member Author

shipilev commented Sep 5, 2025

It looks like GH is using a fleet of Reliant Robins as the runners for macOS arm64. Do you know what value of JTREG_JOBS is used for jtreg --concurrency on these apparently 3-core VMs? If concurrency is >1 then I assume we have more than one stress test running concurrently.

configure step says:

Build performance summary:
* Build jobs:     3
* Memory limit:   7168 MB

TEST_JOBS, AFAICS from build files, follows the number of build jobs, so, 3?

@shipilev
Copy link
Member Author

shipilev commented Sep 5, 2025

Seeing these tests failing often now. I think I need a second reviewer to integrate this, to make testing cleaner.

@AlanBateman
Copy link
Contributor

Seeing these tests failing often now. I think I need a second reviewer to integrate this, to make testing cleaner.

One Reviewer is okay here.

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@shipilev
Copy link
Member Author

shipilev commented Sep 5, 2025

OK, thanks, here goes.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

Going to push as commit 0dad3f1.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 5, 2025
@openjdk openjdk bot closed this Sep 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2025
@openjdk
Copy link

openjdk bot commented Sep 5, 2025

@shipilev Pushed as commit 0dad3f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants