Skip to content

Conversation

@disha-morye
Copy link
Contributor

@disha-morye disha-morye commented Sep 5, 2025

The test is open sourced and is passing on linux. Hence, it can be removed from the Problem List.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366764: Deproblemlist java/awt/ScrollPane/ScrollPositionTest.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27111/head:pull/27111
$ git checkout pull/27111

Update a local copy of the PR:
$ git checkout pull/27111
$ git pull https://git.openjdk.org/jdk.git pull/27111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27111

View PR using the GUI difftool:
$ git pr show -t 27111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27111.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 5, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2025

Hi @disha-morye, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user disha-morye" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

@disha-morye This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366764: Deproblemlist java/awt/ScrollPane/ScrollPositionTest.java

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azvegint) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

@disha-morye To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Sep 8, 2025
@disha-morye
Copy link
Contributor Author

/label client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 9, 2025
@openjdk
Copy link

openjdk bot commented Sep 9, 2025

@disha-morye
The client label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 9, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 9, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 9, 2025

⚠️ @disha-morye the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8366764
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 9, 2025
@disha-morye
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 10, 2025
@openjdk
Copy link

openjdk bot commented Sep 10, 2025

@disha-morye
Your change (at version 9f697c8) is now ready to be sponsored by a Committer.

@manukumarvs
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 10, 2025

Going to push as commit 2705e88.
Since your change was applied there have been 102 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 10, 2025
@openjdk openjdk bot closed this Sep 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 10, 2025
@openjdk
Copy link

openjdk bot commented Sep 10, 2025

@manukumarvs @disha-morye Pushed as commit 2705e88.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants