8262329: Fix JFR parser exception messages

[rkennke]

I've been irritated by unreasonable large constant pool offsets in ChunkParser excepion messages. It turns out that lastCP + size concatenates the two numbers as strings instead of adding them.

Testing:

• manually inspecting the exception messages

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8262329: Fix JFR parser exception messages

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2714/head:pull/2714
$ git checkout pull/2714

[bridgekeeper]

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rkennke The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (9d1caa1)
• 01: Full - Incremental (a0ba7f7)
• 00: Full (33b8bec)

[egahlin]

I'm not sure why there is a check for chunk header? I think the check can be removed, including the static field.

[openjdk]

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262329: Fix JFR parser exception messages

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 8256517: 8262421: doclint warnings in jdk.compiler module
• 29c603f: 8262227: Change SystemDictionary::find() to return an InstanceKlass*.
• 35c0a69: 8262416: ProblemList TestHeapDumpForLargeArray.java due to JDK-8262386
• 228c285: 8261170: Upgrade to freetype 2.10.4
• ded96dd: 8139348: Deprecate 3DES and RC4 in Kerberos
• 5a9b701: 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in subclass overrides
• 7d4f60b: 8260403: javap should be more robust in the face of invalid class files
• 674be87: 8261203: Incorrectly escaped javadoc html with type annotations
• 2eca17d: 8261457: test/langtools/tools/javac/T8187978 can fail if ArrayList class is modified
• c54724d: 8257234: Add gz option to SA jmap to write a gzipped heap dump
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/a50725db2ab621e1a17cb5505f78e4bc73972a27...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rkennke]

I'm not sure why there is a check for chunk header? I think the check can be removed, including the static field.

I am not sure either. From what I can glean from the log message, the intention is to print some information when a constant pool is never used, except for the ChunkHeader.

[jiekang]

I'm not sure why there is a check for chunk header? I think the check can be removed, including the static field.

I am not sure either. From what I can glean from the log message, the intention is to print some information when a constant pool is never used, except for the ChunkHeader.

I think the intention is to log a pool that's never used. Wouldn't that make sense for the ChunkHeader checkpoint that was introduced with event streaming? Is it used elsewhere?

[egahlin]

I'm not sure why there is a check for chunk header? I think the check can be removed, including the static field.

I am not sure either. From what I can glean from the log message, the intention is to print some information when a constant pool is never used, except for the ChunkHeader.

I think the intention is to log a pool that's never used. Wouldn't that make sense for the ChunkHeader checkpoint that was introduced with event streaming? Is it used elsewhere?

All recordings to disk are streaming, so it is emitted once every second, but the chunk header type is only inspected when downloading streaming data over JMX. Anyway, I think it should be treated as other pools and be included.

This time, two wrongs made one right :)

[rkennke]

/integrate

[openjdk]

@rkennke Since your change was applied there have been 35 commits pushed to the master branch:

• a4c2496: 8259535: ECDSA SignatureValue do not always have the specified length
• 2515c42: 8262332: serviceability/sa/ClhsdbJhisto.java fails with Test ERROR java.lang.RuntimeException: 'ParselTongue' missing from stdout/stderr
• 07061fc: 8256417: Exclude TestJFRWithJMX test from running with PodMan
• c9e9189: 8262074: Consolidate the default value of MetaspaceSize
• 05c11bc: 8262426: Change TRAPS to Thread* for find_constrained_instance_or_array_klass()
• d06d6f5: 8262402: Make CATCH macro assert not fatal
• 47a0842: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware
• 3088e1e: 8262430: doclint warnings in java.base module
• 67b9e5a: 8262420: typo: @implnote in java.desktop module
• 240f2a1: 8260366: ExtendedSocketOptions can deadlock in some circumstances
• ... and 25 more: https://git.openjdk.java.net/jdk/compare/a50725db2ab621e1a17cb5505f78e4bc73972a27...master

Your commit was automatically rebased without conflicts.

Pushed as commit 65a245e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.