-
Notifications
You must be signed in to change notification settings - Fork 6k
JDK-8248904: Add support to jpackage for the Mac App Store #2716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back herrick! A progress list of the required criteria for merging this PR into |
@andyherrick The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/csr |
@andyherrick this pull request will not be integrated until the CSR request JDK-8262082 for issue JDK-8248904 has been approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a couple questions. Is JavaApp.icns
intended to be an empty file (I see that the file it was renamed from was empty, so probably OK)? The rest are inline below.
@@ -185,7 +185,7 @@ Generic Options:\n\ | |||
\ Icons, template files, and other resources of jpackage can be\n\ | |||
\ over-ridden by adding replacement resources to this directory.\n\ | |||
\ (absolute path or relative to the current directory)\n\ | |||
\ --runtime-image <file-path>\n\ | |||
\ --runtime-image <file path>\n\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated to this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - it is unrelated, other than I was adding a new help text with the same syntax (--mac-entitlements ) and was looking for consistent way to say "" and found that in all cases except this one we said not so I fixed this one too to make them all consistent.
\ Team or user name portion of Apple signing identities.\n\ | ||
\ --mac-app-store\n\ | ||
\ Indicates that the jpackage output is intended for the\n\ | ||
\ Mac App Store.\n\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe macOS App Store
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I do see it referenced both ways (even by Apple) I see 10 times as many entries in Google for "Mac App Store" (1.7 billion) vs MacOS App Store (155 million)
@andyherrick This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 245 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@andyherrick Since your change was applied there have been 262 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 11c8c78. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Implementation of Mac App Support including three new mac specific CLI options.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2716/head:pull/2716
$ git checkout pull/2716