JDK-8248904: Add support to jpackage for the Mac App Store #2716

andyherrick · 2021-02-24T21:59:22Z

Implementation of Mac App Support including three new mac specific CLI options.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8248904: Add support to jpackage for the Mac App Store

Reviewers

Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)
Alexander Matveev (@sashamatveev - Committer)
Alexander Zuev (@azuev-java - Reviewer)
Kevin Rushforth (@kevinrushforth - Author)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2716/head:pull/2716
$ git checkout pull/2716

bridgekeeper · 2021-02-24T22:00:18Z

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-02-24T22:01:29Z

@andyherrick The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

andyherrick · 2021-02-24T22:08:34Z

/csr

openjdk · 2021-02-24T22:08:50Z

@andyherrick this pull request will not be integrated until the CSR request JDK-8262082 for issue JDK-8248904 has been approved.

mlbridge · 2021-03-08T17:10:25Z

Webrevs

00: Full (8e11eab)

kevinrushforth

Looks good with a couple questions. Is JavaApp.icns intended to be an empty file (I see that the file it was renamed from was empty, so probably OK)? The rest are inline below.

kevinrushforth · 2021-03-10T12:37:03Z

src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties

@@ -185,7 +185,7 @@ Generic Options:\n\
 \          Icons, template files, and other resources of jpackage can be\n\
 \          over-ridden by adding replacement resources to this directory.\n\
 \          (absolute path or relative to the current directory)\n\
-\  --runtime-image <file-path>\n\
+\  --runtime-image <file path>\n\


This seems unrelated to this change.

yes - it is unrelated, other than I was adding a new help text with the same syntax (--mac-entitlements ) and was looking for consistent way to say "" and found that in all cases except this one we said not so I fixed this one too to make them all consistent.

kevinrushforth · 2021-03-10T12:37:32Z

src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties

+\          Team or user name portion of Apple signing identities.\n\
+\  --mac-app-store\n\
+\          Indicates that the jpackage output is intended for the\n\
+\          Mac App Store.\n\


Maybe macOS App Store?

Although I do see it referenced both ways (even by Apple) I see 10 times as many entries in Google for "Mac App Store" (1.7 billion) vs MacOS App Store (155 million)

openjdk · 2021-03-15T20:33:01Z

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8248904: Add support to jpackage for the Mac App Store

Reviewed-by: asemenyuk, almatvee, kizune, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 245 new commits pushed to the master branch:

0c718ab: 8262277: URLClassLoader.getResource throws undocumented IllegalArgumentException
4f1cda4: 8263387: G1GarbageCollection JFR event gets gc phase, not gc type
5ab5244: 8263514: Minor issue in JavacFileManager.SortFiles.REVERSE
771b146: 8245025: MoveAndUpdateClosure::do_addr calls function with side-effects in an assert
46d78f0: 6539707: (fc) MappedByteBuffer.force() method throws an IOException in a very simple test
189289d: 8262326: MaxMetaspaceSize does not have to be aligned to metaspace commit alignment
d825198: 8263556: remove @modules java.base from tests
d6b5e18: 8263191: Consolidate ThreadInVMfromJavaNoAsyncException and ThreadBlockInVMWithDeadlockCheck with existing wrappers
80cdf78: 8263544: Unused argument in ConstantPoolCacheEntry::set_field()
c0176c4: 8263552: Use String.valueOf() for char-to-String conversions
... and 235 more: https://git.openjdk.java.net/jdk/compare/2c99bad082c672b2f1b4dc7792c213b2e9076f57...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

andyherrick · 2021-03-16T17:26:19Z

/integrate

openjdk · 2021-03-16T17:27:23Z

@andyherrick Since your change was applied there have been 262 commits pushed to the master branch:

dc93138: 8256732: Zero: broken +ZeroTLAB exposes badly initialized memory
e33bfb3: 8263450: Simplify LambdaForm.useCount
75ef6f5: 8263427: Shenandoah: Trigger weak-LRB even when heap is stable
4517d72: 8263612: Unused variables in C1 runtime
83a9a02: 8263509: LdapSchemaParser.readNextTag checks array length incorrectly
9c50b8e: 8263587: C2: JVMS not cloned when needs_clone_jvms() is true
68deb24: 8080272: Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy
a31a23d: 8263595: Remove oop type punning in JavaCallArguments
a1f6591: 8263589: Introduce JavaValue::get_oop/set_oop
20297a1: 8263577: C2: reachable nodes shouldn't have dead uses at the end of optimizations
... and 252 more: https://git.openjdk.java.net/jdk/compare/2c99bad082c672b2f1b4dc7792c213b2e9076f57...master

Your commit was automatically rebased without conflicts.

Pushed as commit 11c8c78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8248904: Add support for Mac App Store

5795dc6

openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 24, 2021

andyherrick changed the title ~~JDK-8248904: Add support for Mac App Store~~ JDK-8248904: Add support to jpackage for the Mac App Store Feb 24, 2021

openjdk bot added the csr Pull request needs approved CSR before integration label Feb 24, 2021

andyherrick added 5 commits February 25, 2021 15:24

JDK-8248904: Add support for Mac App Store

9da0185

JDK-8248904: Add support for Mac App Store

bc2f8c6

JDK-8248904: Add support for Mac App Store

a9555ce

JDK-8248904: Add support for Mac App Store

a23e099

JDK-8248904: Add support for Mac App Store

8e11eab

andyherrick marked this pull request as ready for review March 8, 2021 17:06

openjdk bot added the rfr Pull request is ready for review label Mar 8, 2021

alexeysemenyukoracle approved these changes Mar 8, 2021

View reviewed changes

sashamatveev approved these changes Mar 9, 2021

View reviewed changes

azuev-java approved these changes Mar 10, 2021

View reviewed changes

kevinrushforth approved these changes Mar 10, 2021

View reviewed changes

openjdk bot removed the csr Pull request needs approved CSR before integration label Mar 15, 2021

openjdk bot added the ready Pull request is ready to be integrated label Mar 15, 2021

openjdk bot closed this Mar 16, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 16, 2021

andyherrick deleted the JDK-8248904-A branch March 22, 2021 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

JDK-8248904: Add support to jpackage for the Mac App Store #2716

JDK-8248904: Add support to jpackage for the Mac App Store #2716

Uh oh!

andyherrick commented Feb 24, 2021 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Feb 24, 2021

Uh oh!

openjdk bot commented Feb 24, 2021

Uh oh!

andyherrick commented Feb 24, 2021

Uh oh!

openjdk bot commented Feb 24, 2021

Uh oh!

mlbridge bot commented Mar 8, 2021

Uh oh!

kevinrushforth left a comment

Uh oh!

kevinrushforth Mar 10, 2021

Uh oh!

andyherrick Mar 10, 2021

Uh oh!

kevinrushforth Mar 10, 2021

Uh oh!

andyherrick Mar 10, 2021

Uh oh!

openjdk bot commented Mar 15, 2021

Uh oh!

andyherrick commented Mar 16, 2021

Uh oh!

openjdk bot commented Mar 16, 2021

Uh oh!

Uh oh!

JDK-8248904: Add support to jpackage for the Mac App Store #2716

JDK-8248904: Add support to jpackage for the Mac App Store #2716

Uh oh!

Conversation

andyherrick commented Feb 24, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Download

Uh oh!

bridgekeeper bot commented Feb 24, 2021

Uh oh!

openjdk bot commented Feb 24, 2021

Uh oh!

andyherrick commented Feb 24, 2021

Uh oh!

openjdk bot commented Feb 24, 2021

Uh oh!

mlbridge bot commented Mar 8, 2021

Webrevs

Uh oh!

kevinrushforth left a comment

Choose a reason for hiding this comment

Uh oh!

kevinrushforth Mar 10, 2021

Choose a reason for hiding this comment

Uh oh!

andyherrick Mar 10, 2021

Choose a reason for hiding this comment

Uh oh!

kevinrushforth Mar 10, 2021

Choose a reason for hiding this comment

Uh oh!

andyherrick Mar 10, 2021

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Mar 15, 2021

Uh oh!

andyherrick commented Mar 16, 2021

Uh oh!

openjdk bot commented Mar 16, 2021

Uh oh!

Uh oh!

andyherrick commented Feb 24, 2021 •

edited by openjdk bot

Loading