8365483: Test sun/rmi/runtime/Log/6409194/NoConsoleOutput.java sometimes fails #27173
Conversation
|
👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into |
dfuch
left a comment
dfuch
left a comment
There was a problem hiding this comment.
LGTM. Please run tier 2 before integrating.
|
@david-beaumont This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @jaikiran) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@david-beaumont The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
openjdk
bot
added
core-libs
Webrevs
|
dfuch
left a comment
dfuch
left a comment
There was a problem hiding this comment.
Thanks for adding that test @david-beaumont ! The license header needs to be fixed though.
| return null; | ||
| } | ||
| } | ||
| } No newline at end of file |
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. Oracle designates this | ||
| * particular file as subject to the "Classpath" exception as provided | ||
| * by Oracle in the LICENSE file that accompanied this code. |
There was a problem hiding this comment.
Tests should not have the "Classpath" exception.
There was a problem hiding this comment.
Ahh thanks, didn't realize they could not just be copied from source files.
|
/integrate |
|
@david-beaumont |
|
/integrate |
|
@david-beaumont |
|
/sponsor |
|
Going to push as commit 4d4e51c.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
rfr
|
@dfuch @david-beaumont Pushed as commit 4d4e51c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
3 participants
The writer field of the handler needs to be re-checked for null inside the locked region before use.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27173/head:pull/27173$ git checkout pull/27173Update a local copy of the PR:
$ git checkout pull/27173$ git pull https://git.openjdk.org/jdk.git pull/27173/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27173View PR using the GUI difftool:
$ git pr show -t 27173Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27173.diff
Using Webrev
Link to Webrev Comment