8365072: Refactor tests to use PEM API (Phase 2) #27194

myankelev · 2025-09-10T15:18:59Z

Tests changed in this PR:

test/jdk/java/security/cert/CertPathBuilder/selfIssued/StatusLoopDependency.java
test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevel.java
test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevelRevoked.java
test/jdk/sun/security/ssl/ClientHandshaker/RSAExport.java
test/jdk/javax/net/ssl/ServerName/SSLSocketSNISensitive.java
test/jdk/sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java
test/jdk/sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java
test/jdk/javax/net/ssl/interop/ClientHelloInterOp.java
test/jdk/sun/security/rsa/InvalidBitString.java
test/jdk/java/security/cert/CertPathBuilder/NoExtensions.java
test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorTrustAnchor.java
test/jdk/sun/security/x509/X509CRLImpl/Verify.java

PEMRecord tests will be done under a subtask JDK-8367326

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8365072: Refactor tests to use PEM API (Phase 2) (Enhancement - P4)

Reviewers

Anthony Scarpino (@ascarpino - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27194/head:pull/27194
$ git checkout pull/27194

Update a local copy of the PR:
$ git checkout pull/27194
$ git pull https://git.openjdk.org/jdk.git pull/27194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27194

View PR using the GUI difftool:
$ git pr show -t 27194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27194.diff

Using Webrev

Link to Webrev Comment

1. test/jdk/java/security/cert/CertPathBuilder/selfIssued/StatusLoopDependency.java 2. test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevel.java 3. test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevelRevoked.java

6. test/jdk/sun/security/ssl/ClientHandshaker/RSAExport.java 7. test/jdk/javax/net/ssl/ServerName/SSLSocketSNISensitive.java 9. test/jdk/sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java

10. test/jdk/sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java 11. test/jdk/javax/net/ssl/interop/ClientHelloInterOp.java * test/jdk/javax/net/ssl/interop/ClientHelloBufferUnderflowException.java * test/jdk/javax/net/ssl/interop/ClientHelloChromeInterOp.java 12. test/jdk/sun/security/rsa/InvalidBitString.java

…ify.java

bridgekeeper · 2025-09-10T15:20:53Z

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-09-10T15:23:06Z

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365072: Refactor tests to use PEM API (Phase 2)

Reviewed-by: ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1036 new commits pushed to the master branch:

d55e1b4: 8370222: Wrong output for a command in jlink man page
9a88d7f: 8369211: AArch64: Devirtualize class RelocActions
b77b910: 8369349: Add missing CPE headers
... and 1033 more: https://git.openjdk.org/jdk/compare/0ad919c1e54895b000b58f6a1b54d79f76970845...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-09-10T15:24:22Z

@myankelev The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-09-10T15:28:45Z

Webrevs

test/jdk/sun/security/ssl/ClientHandshaker/RSAExport.java

Co-authored-by: Francesco Andreuzzi <andreuzzi.francesco@gmail.com>

ascarpino · 2025-09-26T17:59:09Z

test/jdk/java/security/cert/CertPathBuilder/selfIssued/StatusLoopDependency.java

 import java.security.Security;
-import java.security.cert.*;
-import java.security.cert.CertPathValidatorException.BasicReason;
+import java.security.cert.CertPathBuilder;


Did you intentionally list every java.security.cert class used or did the IDE do that? The changes was made with a number of tests and other import paths, but I'm only mentioning it here. Just a suggestion that * looks cleaner.

Just removing all wildcard imports, when I touch the file. Was asked to remove several times before and in general wildcard is not the best practice, as this affect compile time, which is important for jtreg tests.

ascarpino · 2025-09-26T21:47:19Z

test/jdk/javax/net/ssl/interop/ClientHelloBufferUnderflowException.java

 * @test
 * @bug 8215790 8219389
 * @summary Verify exception
+ * @enablePreview


There doesn't look to be any PEM usage in this test

This class extends ClientHelloInterOp, so needs an updated tag.

ascarpino · 2025-09-26T22:13:57Z

test/jdk/javax/net/ssl/interop/ClientHelloChromeInterOp.java

 * @test
 * @bug 8169362
 * @summary Interop automated testing with Chrome
+ * @enablePreview


Appears not to need PEM

This class extends ClientHelloInterOp, so needs an updated tag.

ascarpino · 2025-09-26T22:15:07Z

test/jdk/javax/net/ssl/interop/ClientHelloInterOp.java

-                KeyFactory kf =
-                    KeyFactory.getInstance(keyMaterialKeyAlgs[i]);
-                PrivateKey priKey = kf.generatePrivate(priKeySpec);
+                String keyMaterialStrPEMFormat = new PEMRecord("PRIVATE KEY", keyMaterialKeys[i]).toString();


Should this one be done with JDK-8367326 instead of this PR?

Yes, you're right, I must have missed this one when removing PEMRecord classes from this PR. I'll change it to not use PEMRecord or move it to JDK-8367326

openjdk · 2025-09-29T10:16:07Z

@myankelev build, client, compiler, core-libs, graal, hotspot, i18n, ide-support, javadoc, jmx, net, nio, serviceability, shenandoah have been added to this pull request based on files touched in new commit(s).

openjdk · 2025-09-29T10:22:40Z

@myankelev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

myankelev · 2025-09-29T10:25:49Z

/help

openjdk · 2025-09-29T10:26:39Z

@myankelev Available commands:

approval - request for maintainer's approval
approve - null
author - sets an overriding author to be used in the commit when the PR is integrated
backport - create a backport
cc - add or remove an additional classification label
clean - Mark the backport pull request as a clean backport
contributor - adds or removes additional contributors for a PR
covered - used when employer has signed the OCA
csr - require a compatibility and specification request (CSR) for this pull request
help - shows this text
integrate - performs integration of the changes in the PR
issue - edit the list of issues that this PR solves
jep - require a JDK Enhancement Proposal (JEP) for this pull request
keepalive - Re-evaluates the pull request and resets the inactivity timeout.
label - add or remove an additional classification label
open - Set the pull request state to "open"
reviewer - manage additional reviewers for a PR
reviewers - set the number of additional required reviewers for this PR
signed - used after signing the OCA
solves - edit the list of issues that this PR solves
sponsor - performs integration of a PR that is authored by a non-committer
summary - updates the summary in the commit message
test - used to run tests
touch - Re-evaluates the pull request and resets the inactivity timeout.

myankelev · 2025-09-29T10:28:37Z

/label remove build,client,compiler,core-libs,graal,hotspot,i18n,ide-support,javadoc,jmx,net,nio,serviceability,shenandoah

openjdk · 2025-09-29T10:31:26Z

@myankelev
The build label was successfully removed.

The client label was successfully removed.

The compiler label was successfully removed.

The core-libs label was successfully removed.

The graal label was successfully removed.

The hotspot label was successfully removed.

The i18n label was successfully removed.

The ide-support label was successfully removed.

The javadoc label was successfully removed.

The jmx label was successfully removed.

The net label was successfully removed.

The nio label was successfully removed.

The serviceability label was successfully removed.

The shenandoah label was successfully removed.

ascarpino

Changes look good.

myankelev · 2025-10-21T23:04:03Z

@ascarpino Thank you for your review! /integrate

myankelev · 2025-10-22T07:48:23Z

/integrate

openjdk · 2025-10-22T07:50:45Z

Going to push as commit 8d9b2fa.
Since your change was applied there have been 1048 commits pushed to the master branch:

eff4b11: 8369322: Implement native stack printing for Windows-AArch64
70e7861: 8370248: AOTMapLogger should check if pointer is in AOTMetaspace
94c0611: 8370122: jpackage test lib improvements
... and 1045 more: https://git.openjdk.org/jdk/compare/0ad919c1e54895b000b58f6a1b54d79f76970845...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-22T07:50:56Z

@myankelev Pushed as commit 8d9b2fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

myankelev added 4 commits August 19, 2025 16:36

JDK-8365072: Refactor tests to use PEM API (Phase 2)

113cc9b

6. test/jdk/sun/security/ssl/ClientHandshaker/RSAExport.java 7. test/jdk/javax/net/ssl/ServerName/SSLSocketSNISensitive.java 9. test/jdk/sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java

converted tests: /NoExtensions.java, CPValidatorTrustAnchor.java, Ver…

2e63af8

…ify.java

openjdk bot changed the title ~~JDK-8365072: Refactor tests to use PEM API (Phase 2)~~ 8365072: Refactor tests to use PEM API (Phase 2) Sep 10, 2025

openjdk bot added security security-dev@openjdk.org rfr Pull request is ready for review labels Sep 10, 2025

fandreuz reviewed Sep 10, 2025

View reviewed changes

test/jdk/sun/security/ssl/ClientHandshaker/RSAExport.java Outdated Show resolved Hide resolved

Francesco's comment

d44cb27

Co-authored-by: Francesco Andreuzzi <andreuzzi.francesco@gmail.com>

ascarpino reviewed Sep 26, 2025

View reviewed changes

myankelev force-pushed the JDK-8365072 branch from e0be5ea to a3323da Compare September 29, 2025 10:21

ascarpino approved these changes Oct 21, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2025

openjdk bot added the integrated Pull request has been integrated label Oct 22, 2025

openjdk bot closed this Oct 22, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 22, 2025

8365072: Refactor tests to use PEM API (Phase 2) #27194

8365072: Refactor tests to use PEM API (Phase 2) #27194

Uh oh!

Conversation

myankelev commented Sep 10, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Sep 10, 2025

Uh oh!

openjdk bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Sep 29, 2025

Uh oh!

openjdk bot commented Sep 29, 2025

Uh oh!

myankelev commented Sep 29, 2025

Uh oh!

openjdk bot commented Sep 29, 2025

Uh oh!

myankelev commented Sep 29, 2025

Uh oh!

openjdk bot commented Sep 29, 2025

Uh oh!

ascarpino left a comment

Choose a reason for hiding this comment

Uh oh!

myankelev commented Oct 21, 2025

Uh oh!

myankelev commented Oct 22, 2025

Uh oh!

openjdk bot commented Oct 22, 2025

Uh oh!

openjdk bot commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

myankelev commented Sep 10, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Sep 10, 2025 •

edited

Loading

openjdk bot commented Sep 10, 2025 •

edited

Loading

mlbridge bot commented Sep 10, 2025 •

edited

Loading