Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs… #272

Closed
wants to merge 1 commit into from

Conversation

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Sep 20, 2020

Fix frame state recording for System.arraycopy() intrinsic. This is port of Graal fix:
oracle/graal@438a7cb

Graal unit test ArrayCopyIntrinsificationTest.java is updated to catch this case.

I ran tier1 and tier3-graal testing. I also ran CodeCacheInfoOnCompilation/Test.java and c2/Test6603011.java jtreg tests 100 times in Mach5 and got 6 failures with latest JDK. With fix tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8247251: Assert '(_pcs_length == 0 || last_pc()->pc_offset() < pc_offset) failed: must specify a new, larger pc offset' failure ⚠️ Title mismatch between PR and JBS.

Reviewers

Contributors

  • Tom Rodriguez <never@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/272/head:pull/272
$ git checkout pull/272

…et) failed: must specify a new, larger pc offset failure
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 20, 2020

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2020

@vnkozlov The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-compiler label Sep 20, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 20, 2020

Webrevs

@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Sep 21, 2020

/contributor add never

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@vnkozlov
Contributor Tom Rodriguez <never@openjdk.org> successfully added.

@tkrodriguez
Copy link
Contributor

@tkrodriguez tkrodriguez commented Sep 22, 2020

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@tkrodriguez Only the author (@vnkozlov) is allowed to issue the reviewer command.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@vnkozlov This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…

Co-authored-by: Tom Rodriguez <never@openjdk.org>
Reviewed-by: never
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 28 commits pushed to the master branch:

  • 3d5fea1: 8253434: Shenandoah: Cleanup ShenandoahRootScanner
  • 8c02bdb: 8252921: NMT overwrite memory type for region assert when building dynamic archive
  • 0c287de: 8253421: Initialize JFR trace-IDs with zero
  • aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
  • ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
  • b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
  • 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
  • a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
  • 96f722c: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC
  • f7b1ce4: 8253447: Remove buggy code introduced by 8249451
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/cc7521c452ad47a9a0bfca23168ac1ff0aff3343...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 3d5fea1f07cd16754528f249a619107bfb414f5c.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 22, 2020
@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Sep 22, 2020

/integrate

@openjdk openjdk bot closed this Sep 22, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@vnkozlov Since your change was applied there have been 28 commits pushed to the master branch:

  • 3d5fea1: 8253434: Shenandoah: Cleanup ShenandoahRootScanner
  • 8c02bdb: 8252921: NMT overwrite memory type for region assert when building dynamic archive
  • 0c287de: 8253421: Initialize JFR trace-IDs with zero
  • aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
  • ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
  • b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
  • 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
  • a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
  • 96f722c: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC
  • f7b1ce4: 8253447: Remove buggy code introduced by 8249451
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/cc7521c452ad47a9a0bfca23168ac1ff0aff3343...master

Your commit was automatically rebased without conflicts.

Pushed as commit 24e12b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 22, 2020
@vnkozlov vnkozlov deleted the vnkozlov:JDK-8247251 branch Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.