-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems
#27230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systemstest/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems
|
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3162 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @tschatzl, @Hamlin-Li) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
/sponsor |
|
Going to push as commit 0f535ae.
Your commit was automatically rebased without conflicts. |
|
@Hamlin-Li @satyenme Pushed as commit 0f535ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
@Hamlin-Li : same as the other PR, please respect the 24h rule when sponsoring. The author did not even suggest that it is trivial. Thanks. |
On 32-bit systems, the
test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.javauses theObjectAlignmentInBytesflag, which isn't supported on 32 bit systems. I'm adjusting this test to requirevm.bitsis 64 as per similar tests.Tested on:
Note: seeing some GHA failures, but unrelated to the actual test.
Progress
Issue
test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.javafails on 32 bit systems (Bug - P4)Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27230/head:pull/27230$ git checkout pull/27230Update a local copy of the PR:
$ git checkout pull/27230$ git pull https://git.openjdk.org/jdk.git pull/27230/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27230View PR using the GUI difftool:
$ git pr show -t 27230Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27230.diff
Using Webrev
Link to Webrev Comment