Skip to content

Conversation

@satyenme
Copy link
Contributor

@satyenme satyenme commented Sep 11, 2025

On 32-bit systems, the test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java uses the ObjectAlignmentInBytes flag, which isn't supported on 32 bit systems. I'm adjusting this test to require vm.bits is 64 as per similar tests.

Tested on:

  • 64-bit: with and without change (passes both times)
  • 32-bit: with and without change (fails before, skips after)
    Note: seeing some GHA failures, but unrelated to the actual test.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27230/head:pull/27230
$ git checkout pull/27230

Update a local copy of the PR:
$ git checkout pull/27230
$ git pull https://git.openjdk.org/jdk.git pull/27230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27230

View PR using the GUI difftool:
$ git pr show -t 27230

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27230.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@satyenme satyenme changed the title JDK-8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems 8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems Sep 11, 2025
@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367372: Test `test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java` fails on 32 bit systems

Reviewed-by: stefank, tschatzl, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3162 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @tschatzl, @Hamlin-Li) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@satyenme The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review labels Sep 11, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 11, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 11, 2025
@satyenme
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 11, 2025
@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@satyenme
Your change (at version 485aac3) is now ready to be sponsored by a Committer.

@Hamlin-Li
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

Going to push as commit 0f535ae.
Since your change was applied there have been 3163 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2025
@openjdk openjdk bot closed this Sep 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@Hamlin-Li @satyenme Pushed as commit 0f535ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl
Copy link
Contributor

@Hamlin-Li : same as the other PR, please respect the 24h rule when sponsoring. The author did not even suggest that it is trivial. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants