8260403: javap should be more robust in the face of invalid class files

[asotona]

Please review javap fix to handle java.lang.IllegalStateException for classes with invalid Signature attribute.
New test (T8260403) parsing class with invalid Signature attribute (as described in the bug) is included.
Fix wraps java.lang.IllegalStateException, reports "Error: Invalid value for Signature attribute: " and continues.

Thanks,
Adam

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260403: javap should be more robust in the face of invalid class files

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2724/head:pull/2724
$ git checkout pull/2724

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7e73e70)

[vicente-romero-oracle]

lgtm!

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260403: javap should be more robust in the face of invalid class files

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 674be87: 8261203: Incorrectly escaped javadoc html with type annotations
• 2eca17d: 8261457: test/langtools/tools/javac/T8187978 can fail if ArrayList class is modified
• c54724d: 8257234: Add gz option to SA jmap to write a gzipped heap dump
• aa35b42: 8261131: jcmd jmap dump should not accept gz option with no value
• ebdc80e: 8252883: AccessDeniedException caused by delayed file deletion on Windows
• f79c626: 8262296: Fix remaining doclint warnings in jdk.httpserver

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[asotona]

/integrate

[openjdk]

@asotona
Your change (at version 7e73e70) is now ready to be sponsored by a Committer.

[jonathan-gibbons]

/sponsor

[openjdk]

@jonathan-gibbons @asotona Since your change was applied there have been 6 commits pushed to the master branch:

• 674be87: 8261203: Incorrectly escaped javadoc html with type annotations
• 2eca17d: 8261457: test/langtools/tools/javac/T8187978 can fail if ArrayList class is modified
• c54724d: 8257234: Add gz option to SA jmap to write a gzipped heap dump
• aa35b42: 8261131: jcmd jmap dump should not accept gz option with no value
• ebdc80e: 8252883: AccessDeniedException caused by delayed file deletion on Windows
• f79c626: 8262296: Fix remaining doclint warnings in jdk.httpserver

Your commit was automatically rebased without conflicts.

Pushed as commit 7d4f60b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.