8365790: Shutdown hook for application image does not work on Windows

[alexeysemenyukoracle]

Disable the default handling of Ctrl+C in the parent app launcher process to let the child app launcher running JVM handle it. Add corresponding test case.

The new test is crafted to work (skip) in the environment where Ctrl+C signal emitted from the PowerShell script doesn't go through to a child process.

Supplementary changes:

• Added convenience api to CfgFile;
• Fixed TKit.waitForFileCreated() function to work correctly when multiple files are monitored in the same directory and to call close() on the WatchService instance.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365790: Shutdown hook for application image does not work on Windows (Bug - P3)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27264/head:pull/27264
$ git checkout pull/27264

Update a local copy of the PR:
$ git checkout pull/27264
$ git pull https://git.openjdk.org/jdk.git pull/27264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27264

View PR using the GUI difftool:
$ git pr show -t 27264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27264.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365790: Shutdown hook for application image does not work on Windows

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 105 new commits pushed to the master branch:

• 18dc186: 8367790: Remove java/awt/PopupMenu/PopupMenuLocation.java from ProblemList
• 6f493b4: 8361699: C2: assert(can_reduce_phi(n->as_Phi())) failed: Sanity: previous reducible Phi is no longer reducible before SUT
• 01d7554: 8367486: Change prefix for platform-dependent AtomicAccess files
• ... and 102 more: https://git.openjdk.org/jdk/compare/c968a672c034fe533ea5f4ac5efe37ffb76c93e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (c63a7582)
• 03: Full - Incremental (d8ad4975)
• 02: Full - Incremental (7a597c68)
• 01: Full - Incremental (df6d8318)
• 00: Full (4464486f)

[sashamatveev]

Looks good. I assume parent process will terminate as well after child process?

[alexeysemenyukoracle]

Thank you for the review. The child process will automatically terminate when the parent terminates and vice versa.

The fix disables Ctrl+C event handling in the parent process to let the child process handle it. When a Ctrl+C event occurs, the child process running the JVM terminates, automatically terminating the parent process.

[alexeysemenyukoracle]

Reworked the test to work (skip) in the environment where GenerateConsoleCtrlEvent() function called from the PowerShell script doesn't go through to a child process.

[alexeysemenyukoracle]

@sashamatveev please review again

[sashamatveev]

Latest changes looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit f7ce3a1.
Since your change was applied there have been 105 commits pushed to the master branch:

• 18dc186: 8367790: Remove java/awt/PopupMenu/PopupMenuLocation.java from ProblemList
• 6f493b4: 8361699: C2: assert(can_reduce_phi(n->as_Phi())) failed: Sanity: previous reducible Phi is no longer reducible before SUT
• 01d7554: 8367486: Change prefix for platform-dependent AtomicAccess files
• ... and 102 more: https://git.openjdk.org/jdk/compare/c968a672c034fe533ea5f4ac5efe37ffb76c93e2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit f7ce3a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.