Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262389: Use permitted_enctypes if default_tkt_enctypes or default_tgs_enctypes is not present #2729

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Feb 25, 2021

When default_tkt_enctypes or default_tgs_enctypes, use the value of permitted_enctypes if it exists.

Please also review the CSR at https://bugs.openjdk.java.net/browse/JDK-8262391 and release note at https://bugs.openjdk.java.net/browse/JDK-8262401.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262389: Use permitted_enctypes if default_tkt_enctypes or default_tgs_enctypes is not present

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2729/head:pull/2729
$ git checkout pull/2729

Update a local copy of the PR:
$ git checkout pull/2729
$ git pull https://git.openjdk.java.net/jdk pull/2729/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2729

View PR using the GUI difftool:
$ git pr show -t 2729

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2729.diff

…s_enctypes is not present

8262389: Use permitted_enctypes if default_tkt_enctypes or default_tgs_enctypes is not present
@wangweij
Copy link
Contributor Author

wangweij commented Feb 25, 2021

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Feb 25, 2021
@openjdk
Copy link

openjdk bot commented Feb 25, 2021

@wangweij this pull request will not be integrated until the CSR request JDK-8262391 for issue JDK-8262389 has been approved.

@openjdk
Copy link

openjdk bot commented Feb 25, 2021

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Feb 25, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2021

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Apr 6, 2021
@openjdk
Copy link

openjdk bot commented Apr 6, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262389: Use permitted_enctypes if default_tkt_enctypes or default_tgs_enctypes is not present

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 569 new commits pushed to the master branch:

  • bfb034a: 8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working
  • a756d8d: 8264759: x86_32 Minimal VM build failure after JDK-8262355
  • 0f13e22: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"
  • 4bb80f3: 8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out
  • 2f51699: 8264554: X509KeyManagerImpl calls getProtectionParameter with incorrect alias
  • 114e3c3: 8263856: Github Actions for macos/aarch64 cross-build
  • a611c46: 8264048: Fix caching in Jar URL connections when an entry is missing
  • bf26a25: 8264027: Refactor "CLEANUP" region printing
  • eb6330e: 8264047: Duplicate global variable 'jvm' in libjavajpeg and libawt
  • 8132548: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested
  • ... and 559 more: https://git.openjdk.java.net/jdk/compare/ded96ddcde1e9e8556a6ce8948acef27b6e192cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 6, 2021
@wangweij
Copy link
Contributor Author

wangweij commented Apr 6, 2021

/integrate

@openjdk openjdk bot closed this Apr 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2021
@openjdk
Copy link

openjdk bot commented Apr 6, 2021

@wangweij Since your change was applied there have been 569 commits pushed to the master branch:

  • bfb034a: 8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working
  • a756d8d: 8264759: x86_32 Minimal VM build failure after JDK-8262355
  • 0f13e22: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"
  • 4bb80f3: 8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out
  • 2f51699: 8264554: X509KeyManagerImpl calls getProtectionParameter with incorrect alias
  • 114e3c3: 8263856: Github Actions for macos/aarch64 cross-build
  • a611c46: 8264048: Fix caching in Jar URL connections when an entry is missing
  • bf26a25: 8264027: Refactor "CLEANUP" region printing
  • eb6330e: 8264047: Duplicate global variable 'jvm' in libjavajpeg and libawt
  • 8132548: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested
  • ... and 559 more: https://git.openjdk.java.net/jdk/compare/ded96ddcde1e9e8556a6ce8948acef27b6e192cc...master

Your commit was automatically rebased without conflicts.

Pushed as commit eb5c097.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8262389 branch Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants