8333526: Restructure java/nio/channels/DatagramChannel/StressNativeSignal.java to a fail fast exception handling policy

[serhiysachkov]

This task addresses the restructuring of the test to handle exception, especially during test setup, in a more immediate "fail fast" manner.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333526: Restructure java/nio/channels/DatagramChannel/StressNativeSignal.java to a fail fast exception handling policy (Enhancement - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27294/head:pull/27294
$ git checkout pull/27294

Update a local copy of the PR:
$ git checkout pull/27294
$ git pull https://git.openjdk.org/jdk.git pull/27294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27294

View PR using the GUI difftool:
$ git pr show -t 27294

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27294.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serhiysachkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@serhiysachkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333526: Restructure java/nio/channels/DatagramChannel/StressNativeSignal.java to a fail fast exception handling policy

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 185 new commits pushed to the master branch:

• ba44656: 8366454: TLS1.3 server fails with bad_record_mac when receiving encrypted records with empty body
• 847b107: 8365191: Cleanup after removing LockingMode related code
• e6ddb39: 8368525: nmethod ic cleanup
• ... and 182 more: https://git.openjdk.org/jdk/compare/1cb1267ce84dea2bfcb434b03c982b859997c6d2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@serhiysachkov The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (aa644f58)
• 00: Full (be1f24c1)

[dfuch]

The refactoring looks good generally but why are we explicitely using ports 1122 and 19870?

[serhiysachkov]

The refactoring looks good generally but why are we explicitely using ports 1122 and 19870?

not sure about the original purpose of using specific ports, but it changed to 0 as suggested.

[bplb]

The changes look reasonable to me.

[serhiysachkov]

/integrate

[openjdk]

@serhiysachkov
Your change (at version aa644f5) is now ready to be sponsored by a Committer.

[msheppar]

/sponsor

[openjdk]

Going to push as commit 4f4030a.
Since your change was applied there have been 187 commits pushed to the master branch:

• d85e410: 8368546: java/net/httpclient/RedirectTimeoutTest.java fails intermittently for HTTP/3 in tier7
• d407ef6: 8368251: Parallel: Refactor lgrp_id used in MutableNUMASpace
• ba44656: 8366454: TLS1.3 server fails with bad_record_mac when receiving encrypted records with empty body
• ... and 184 more: https://git.openjdk.org/jdk/compare/1cb1267ce84dea2bfcb434b03c982b859997c6d2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@msheppar @serhiysachkov Pushed as commit 4f4030a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.