Skip to content

8365823: Revert storing abstract and interface Klasses to non-class metaspace #27295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

8365823: Revert storing abstract and interface Klasses to non-class metaspace #27295

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ec610f4
8365823: Revert storing abstract and interface Klasses to non-class m…
coleenp Aug 20, 2025
864e938
8365823: Revert storing abstract and interface Klasses to non-class m…
coleenp Sep 12, 2025
48d0c6f
Restore comment.
coleenp Sep 15, 2025
2471bf5
Update src/hotspot/share/memory/metaspace.cpp
coleenp Sep 15, 2025
097c6b3
Update src/hotspot/share/memory/metaspace.cpp
coleenp Sep 15, 2025
fe44431
Remove CFP.is_abstract().
coleenp Sep 15, 2025
c333b8a
Revert JFR changes from JDK-8338526 also.
coleenp Sep 18, 2025
f1d08d6
Some limited additional cleanup to HotSpotMetaspaceConstantImpl.java …
coleenp Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdKlassQueue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "jfr/support/jfrThreadLocal.hpp"
#include "jfr/utilities/jfrEpochQueue.inline.hpp"
#include "jfr/utilities/jfrTypes.hpp"
#include "memory/metaspace.hpp"
#include "oops/compressedKlass.inline.hpp"
#include "utilities/macros.hpp"

Expand Down Expand Up @@ -73,14 +74,13 @@ static size_t element_size(bool compressed) {
return compressed ? NARROW_ELEMENT_SIZE : ELEMENT_SIZE;
}

static bool can_compress_element(const Klass* klass) {
return CompressedKlassPointers::is_encodable(klass) &&
JfrTraceId::load_raw(klass) < uncompressed_threshold;
static bool can_compress_element(traceid id) {
return Metaspace::using_class_space() && id < uncompressed_threshold;
}

static size_t element_size(const Klass* klass) {
assert(klass != nullptr, "invariant");
return element_size(can_compress_element(klass));
return element_size(can_compress_element(JfrTraceId::load_raw(klass)));
}

static bool is_unloaded(traceid id, bool previous_epoch) {
Expand Down Expand Up @@ -136,8 +136,7 @@ static inline void store_traceid(JfrEpochQueueNarrowKlassElement* element, trace
}

static void store_compressed_element(traceid id, const Klass* klass, u1* pos) {
assert(can_compress_element(klass), "invariant");
assert(id == JfrTraceId::load_raw(klass), "invariant");
assert(can_compress_element(id), "invariant");
JfrEpochQueueNarrowKlassElement* const element = new (pos) JfrEpochQueueNarrowKlassElement();
store_traceid(element, id);
element->compressed_klass = encode(klass);
Expand All @@ -153,7 +152,7 @@ static void store_element(const Klass* klass, u1* pos) {
assert(pos != nullptr, "invariant");
assert(klass != nullptr, "invariant");
const traceid id = JfrTraceId::load_raw(klass);
if (can_compress_element(klass)) {
if (can_compress_element(id)) {
store_compressed_element(id, klass, pos);
return;
}
Expand Down