8367728: IGV: dump node address type

[robcasloz]

This changeset dumps the address type of each node (Node::adr_type()), when not null, into the IGV graphs. This should improve the visibility and diagnosability of C2 type inconsistencies, see e.g. JDK-8367667.

Testing

• tier1 (windows-x64, linux-x64, linux-aarch64, macosx-x64, and macosx-aarch64; release and debug mode).
• Tested IGV manually on a few selected graphs. Tested automatically that dumping thousands of graphs does not trigger any assertion failure (by running java -Xcomp -XX:PrintIdealGraphLevel=1).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8367728: IGV: dump node address type (Enhancement - P4)

Reviewers

• Marc Chevalier (@marc-chevalier - Committer)
• Damon Fenacci (@dafedafe - Committer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27310/head:pull/27310
$ git checkout pull/27310

Update a local copy of the PR:
$ git checkout pull/27310
$ git pull https://git.openjdk.org/jdk.git pull/27310/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27310

View PR using the GUI difftool:
$ git pr show -t 27310

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27310.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367728: IGV: dump node address type

Reviewed-by: mchevalier, dfenacci, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

• c28142e: 8367737: Parallel: Retry allocation after lock acquire in mem_allocate_work
• 6df0117: 8356779: IGV: dump the index of the SafePointNode containing the current JVMS during parsing
• faebec6: 8367532: Declare all stubgen stub entries including internal cross-stub entries
• ... and 75 more: https://git.openjdk.org/jdk/compare/3d679087b0376c221d536780cee387dc2dd8019e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@robcasloz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (73eb2bb0)

[marc-chevalier]

I'm happy.

[dafedafe]

Strange that it wasn't already printed 🙂 Thanks for adding this @robcasloz! LGTM

[chhagedorn]

Looks good!

[robcasloz]

Thanks for reviewing Marc, Damon, and Christian!

[robcasloz]

/integrate

[openjdk]

Going to push as commit b00e0da.
Since your change was applied there have been 80 commits pushed to the master branch:

• 7e738f0: 8367313: CTW: Execute in AWT headless mode
• 4719ed6: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64
• c28142e: 8367737: Parallel: Retry allocation after lock acquire in mem_allocate_work
• ... and 77 more: https://git.openjdk.org/jdk/compare/3d679087b0376c221d536780cee387dc2dd8019e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robcasloz Pushed as commit b00e0da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.