8261670: Add javadoc for the XML processing limits #2732

JoeWang-Java · 2021-02-25T22:04:41Z

Add the documentation for XML processing limits to module summary. The limits were previously documented in Java tutorial and guide.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8261670: Add javadoc for the XML processing limits

Reviewers

Lance Andersen (@LanceAndersen - Reviewer)
Naoto Sato (@naotoj - Reviewer)
Iris Clark (@irisclark - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2732/head:pull/2732
$ git checkout pull/2732

bridgekeeper · 2021-02-25T22:04:49Z

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-02-25T22:06:08Z

@JoeWang-Java The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-02-25T22:09:50Z

Webrevs

naotoj · 2021-02-25T22:28:43Z

src/java.xml/share/classes/module-info.java

+ * <td rowspan="9">Integer</td>
+ * <th id="Value" scope="row" style="font-weight:normal" rowspan="9">
+ * A positive integer. A value less than or equal to 0 indicates no limit.
+ * If the value is not an integer, a NumericFormatException is thrown.


Is it a NumberFormatException? Also, @link might be useful here.

Oh my, the typo has been in the tutorial all this time! It's NumberFormatException indeed.

naotoj · 2021-02-25T22:33:02Z

src/java.xml/share/classes/module-info.java

+ * A positive integer. A value less than or equal to 0 indicates no limit.
+ * If the value is not an integer, a NumericFormatException is thrown.
+ * </th>
+ * <th id="Default" scope="row" style="font-weight:normal">64000</th>


There are other Default ids in other rows. Should they be distinct? Or rather needed?

True, not needed. Will remove, and also look at other copy&paste-d ids.

JoeWang-Java · 2021-02-25T22:34:24Z

/csr

openjdk · 2021-02-25T22:34:40Z

@JoeWang-Java this pull request will not be integrated until the CSR request JDK-8262427 for issue JDK-8261670 has been approved.

LanceAndersen

Looks good Joe. Added myself as a reviewer to the CSR as well

naotoj

Looks good. Thanks for making the changes.

irisclark

Looks good. I'm glad to see useful information from the outdated guides/tutorial being integrated into this documentation.

openjdk · 2021-03-01T23:25:05Z

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261670: Add javadoc for the XML processing limits

Reviewed-by: lancea, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

353416f: 8262509: JSSE Server should check the legacy version in TLSv1.3 ClientHello
642f45f: 8261839: Error creating runtime package on macos without mac-package-identifier
682e120: 8262497: Delete unused utility methods in ICC_Profile class
4c9adce: 8262379: Add regression test for JDK-8257746
6baecf3: 8259937: guarantee(loc != NULL) failed: missing saved register with native invoker
c569f1d: 8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux
75bf106: 8262028: Make InstanceKlass::implementor return InstanceKlass
fe8e370: 8262188: Add test to verify trace page sizes logging on Linux
0a7fff4: 8261636: The test mapping in hugetlbfs_sanity_check should consider LargePageSizeInBytes
702ca62: 8262185: G1: Prune collection set candidates early
... and 20 more: https://git.openjdk.java.net/jdk/compare/722142ee6c811571c1a5423354c135672fd115ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

…t of the properties is not exhaustive

JoeWang-Java · 2021-03-02T03:25:57Z

Thanks all for the review.
/integrate

openjdk · 2021-03-02T03:26:53Z

@JoeWang-Java Since your change was applied there have been 34 commits pushed to the master branch:

85b774a: 8255859: Incorrect comments in log.hpp
c3eb80e: 8262500: HostName entry in VM.info should be a new line
9f0f0c9: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings
d339832: 8257414: Drag n Drop target area is wrong on high DPI systems
353416f: 8262509: JSSE Server should check the legacy version in TLSv1.3 ClientHello
642f45f: 8261839: Error creating runtime package on macos without mac-package-identifier
682e120: 8262497: Delete unused utility methods in ICC_Profile class
4c9adce: 8262379: Add regression test for JDK-8257746
6baecf3: 8259937: guarantee(loc != NULL) failed: missing saved register with native invoker
c569f1d: 8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux
... and 24 more: https://git.openjdk.java.net/jdk/compare/722142ee6c811571c1a5423354c135672fd115ff...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6635d7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8261670: Add javadoc for the XML processing limits

e56793a

openjdk bot added the rfr Pull request is ready for review label Feb 25, 2021

openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 25, 2021

naotoj reviewed Feb 25, 2021

View reviewed changes

openjdk bot added the csr Pull request needs approved CSR before integration label Feb 25, 2021

Merge branch 'master' into JDK-8261670

0169507

openjdk bot removed the rfr Pull request is ready for review label Feb 26, 2021

s/NumericFormatException/NumberFormatException, remove default id

3e555d2

openjdk bot added the rfr Pull request is ready for review label Feb 26, 2021

LanceAndersen approved these changes Feb 26, 2021

View reviewed changes

naotoj approved these changes Feb 26, 2021

View reviewed changes

irisclark approved these changes Feb 26, 2021

View reviewed changes

openjdk bot removed the csr Pull request needs approved CSR before integration label Mar 1, 2021

openjdk bot added the ready Pull request is ready to be integrated label Mar 1, 2021

Change the description of the property table to indicate that the lis…

9be83cb

…t of the properties is not exhaustive

LanceAndersen approved these changes Mar 2, 2021

View reviewed changes

irisclark approved these changes Mar 2, 2021

View reviewed changes

naotoj approved these changes Mar 2, 2021

View reviewed changes

openjdk bot closed this Mar 2, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2021

JoeWang-Java deleted the JDK-8261670 branch March 2, 2021 19:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8261670: Add javadoc for the XML processing limits #2732

8261670: Add javadoc for the XML processing limits #2732

JoeWang-Java commented Feb 25, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Feb 25, 2021

openjdk bot commented Feb 25, 2021

mlbridge bot commented Feb 25, 2021 •

edited

Loading

naotoj Feb 25, 2021

JoeWang-Java Feb 25, 2021

naotoj Feb 25, 2021

JoeWang-Java Feb 25, 2021

JoeWang-Java commented Feb 25, 2021

openjdk bot commented Feb 25, 2021

LanceAndersen left a comment

naotoj left a comment

irisclark left a comment

openjdk bot commented Mar 1, 2021 •

edited

Loading

JoeWang-Java commented Mar 2, 2021

openjdk bot commented Mar 2, 2021

8261670: Add javadoc for the XML processing limits #2732

8261670: Add javadoc for the XML processing limits #2732

Conversation

JoeWang-Java commented Feb 25, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Feb 25, 2021

openjdk bot commented Feb 25, 2021

mlbridge bot commented Feb 25, 2021 • edited Loading

Webrevs

naotoj Feb 25, 2021

Choose a reason for hiding this comment

JoeWang-Java Feb 25, 2021

Choose a reason for hiding this comment

naotoj Feb 25, 2021

Choose a reason for hiding this comment

JoeWang-Java Feb 25, 2021

Choose a reason for hiding this comment

JoeWang-Java commented Feb 25, 2021

openjdk bot commented Feb 25, 2021

LanceAndersen left a comment

Choose a reason for hiding this comment

naotoj left a comment

Choose a reason for hiding this comment

irisclark left a comment

Choose a reason for hiding this comment

openjdk bot commented Mar 1, 2021 • edited Loading

JoeWang-Java commented Mar 2, 2021

openjdk bot commented Mar 2, 2021

JoeWang-Java commented Feb 25, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Feb 25, 2021 •

edited

Loading

openjdk bot commented Mar 1, 2021 •

edited

Loading