8262402: Make CATCH macro assert not fatal

[coleenp]

Hopefully, this is a trivial change. Tested with tier1 on linux, macosx, and windows, product and debug.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8262402: Make CATCH macro assert not fatal

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2736/head:pull/2736
$ git checkout pull/2736

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cd5d036)

[dholmes-ora]

Looks good and trivial.

Thanks,
David

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262402: Make CATCH macro assert not fatal

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks David.
/integrate

[openjdk]

@coleenp Since your change was applied there have been 11 commits pushed to the master branch:

• 47a0842: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware
• 3088e1e: 8262430: doclint warnings in java.base module
• 67b9e5a: 8262420: typo: @implnote in java.desktop module
• 240f2a1: 8260366: ExtendedSocketOptions can deadlock in some circumstances
• de3f519: 8258897: wrong translation of capturing local classes inside nested lambdas
• d7efb4c: 8262199: issue in jli args.c
• 7603278: 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
• 0a4e710: 8261954: Dependencies: Improve iteration over class hierarchy under context class
• 722142e: 8261520: JDK-8261302 breaks runtime/NMT/CheckForProperDetailStackTrace.java
• bcca100: 4710675: JTextArea.setComponentOrientation does not work with correct timing
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/059ede0d2054abe27be220643cccf8a56c4edea8...master

Your commit was automatically rebased without conflicts.

Pushed as commit d06d6f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.