Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259070: Add jcmd option to dump CDS #2737

Closed
wants to merge 17 commits into from
Closed
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

@@ -211,7 +211,7 @@ private static boolean containsExcludedFlags(String testStr) {
testStr.contains("-XX:+DynamicDumpSharedSpaces") ||
testStr.contains("-XX:+RecordDynamicDumpInfo");
}
This conversation was marked as resolved by yminqi

This comment has been minimized.

@iklam

iklam Mar 10, 2021
Member

The following flags should also be excluded:

  • -XX:-DumpSharedSpaces
  • -Xshare:
  • -XX:SharedClassListFile=
  • -XX:SharedArchiveFile=
  • -XX:ArchiveClassesAtExit=
  • -XX:+UseSharedSpaces
  • -XX:+RequireSharedSpaces

We also need to have a few test cases when the LingeredApp is started with these flags.

This comment has been minimized.

@yminqi

yminqi Mar 11, 2021
Author Contributor

Added String[] for those flags to check.


/**
* called from jcmd VM.cds to dump static or dynamic shared archive
* @param isStatic indicates dump static archive of dynnamic archive.
@@ -238,7 +238,7 @@ private static void dumpSharedArchive(boolean isStatic, String fileName) throws
String[] vmArgs = getVMArguments();
if (vmArgs != null) {
for (String arg : vmArgs) {
if (arg != null && !containsExcludedFlags(arg)) {
if (arg != null && !containsExcludedFlags(arg)) {
cmds.add(arg);
}
}
ProTip! Use n and p to navigate between commits in a pull request.