8367988: NewFileSystemTests.readOnlyZipFileFailure fails when run by root user

[fandreuz]

I propose a small patch to skip a tier2 test which fails when it runs as the root user. The test expects an exception when it tries to open a read-only file as rw, but this does not happen for the root user.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8367988: NewFileSystemTests.readOnlyZipFileFailure fails when run by root user (Enhancement - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27376/head:pull/27376
$ git checkout pull/27376

Update a local copy of the PR:
$ git checkout pull/27376
$ git pull https://git.openjdk.org/jdk.git pull/27376/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27376

View PR using the GUI difftool:
$ git pr show -t 27376

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27376.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367988: NewFileSystemTests.readOnlyZipFileFailure fails when run by root user

Reviewed-by: jpai, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• 4b544f9: 8365379: SU3.applyInsets may produce wrong results
• 25a4e26: 8367613: Test compiler/runtime/TestDontCompileHugeMethods.java failed
• 3d4e049: 8367780: Enable UseAPX on Intel CPUs only when both APX_F and APX_NCI_NDD_NF cpuid features are present
• ... and 32 more: https://git.openjdk.org/jdk/compare/feaa654b1bb5a1187785320603ccb17e2c43222d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fandreuz The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (21d104a0)
• 00: Full (8e356f79)

[jaikiran]

This looks OK to me. I think it might have been better if we had a @requires instruction for this, but we don't have that right now. So it's OK to use this construct instead.

Please wait a while before integrating - it would be good to hear from Alan @AlanBateman or Brian @bplb if this change is OK.

[bplb]

it would be good to hear from Alan @AlanBateman or Brian @bplb if this change is OK

I think it looks okay.

[bplb]

If this test were converted to JUnit 5, then I think @DisabledIf could be used here.

[fandreuz]

I wanted to get rid of this test failure, I'll file a ticket to follow up with conversion to JUnit 5 for this and a couple other adjacent test classes

[AlanBateman]

If this test were converted to JUnit 5, then I think @DisabledIf could be used here.

Yes, or the Assumptions API, both would work.

[fandreuz]

/integrate

[openjdk]

@fandreuz
Your change (at version 21d104a) is now ready to be sponsored by a Committer.

[sendaoYan]

/sponsor

[openjdk]

Going to push as commit b03b6f5.
Since your change was applied there have been 36 commits pushed to the master branch:

• 5a684e3: 8368029: Several tests in httpserver/simpleserver should throw SkipException
• 4b544f9: 8365379: SU3.applyInsets may produce wrong results
• 25a4e26: 8367613: Test compiler/runtime/TestDontCompileHugeMethods.java failed
• ... and 33 more: https://git.openjdk.org/jdk/compare/feaa654b1bb5a1187785320603ccb17e2c43222d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan @fandreuz Pushed as commit b03b6f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.