New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253397: Ensure LogTag types are sorted #274
Conversation
👋 Welcome back redestad! A progress list of the required criteria for merging this PR into |
@cl4es The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine.
Thanks
@cl4es This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
There are currently no new commits on the ➡️ To integrate this PR with the above commit message to the |
Mailing list message from Kim Barrett on hotspot-runtime-dev: I think having the LOG_TAG_LIST in sorted order is good. But I think the checking can be improved. I think it can be done at Make LogTag::_name constexpr (it should at least be const, and it's a (I think the sorting could be done at compile-time too, unless that requires |
Mailing list message from Kim Barrett on hotspot-runtime-dev:
It's not hard to make the is_sorted check constexpr, but doesn't provide a A pre-existing thing that should be fixed though: That should be And similarly in the .cpp file. Looks good with the above change. |
/integrate |
@cl4es Please do not force push updates to a PR. There is no way for reviewers to see what, if anything, differs between the final commit and the commit that they reviewed. If you want to merge with mainline/master then just merge and push the new commit to your personal fork. The commits will be flattened as part of the actual integration. Thanks. |
@dholmes-ora: fwiw, there is: click on the actual commit link (e.g. 19d37e7 in this case where it says " cl4es added 2 commits 4 days ago ") and you'll get a diff in github. There is an enhancement/bug open on skara for better support of diffs for force pushes. |
@dholmes-ora once I ended up in a state where force-push seemed like the only option it was too late. I assure you there were no changes from the reviewed changeset, and since there were no inline comments little I figured little was lost. I believe a |
That is a diff for one of the commits that was force-pushed over the original. I can see diffs both of those commits but what I cannot see is how those commits differ to the original one that was overwritten. Further if I click on "Show changes since your last review" I get an error page: "We went looking everywhere, but couldn’t find those commits. We don't need better support for forced pushes IMO we just need to not do them. Cheers. |
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/274/head:pull/274
$ git checkout pull/274