8368206: RISC-V: compiler/vectorapi/VectorMaskCompareNotTest.java fails when running without RVV

[DingliZhang]

Hi,
Can you help to review this patch? Thanks!

We noticed that compiler/vectorapi/VectorMaskCompareNotTest.java fails when running on sg2042.
On RISC-V without RVV, ofLargestShape(long.class) falls back to 64 bits (see getMaxVectorBitSize in VectorShape.java),
leading to VectorShape.forBitSize(32) which is unsupported and throws IllegalArgumentException.

Test (fastdebug)

• Run compiler/vectorapi/VectorMaskCompareNotTest.java on sg2042

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368206: RISC-V: compiler/vectorapi/VectorMaskCompareNotTest.java fails when running without RVV (Bug - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Manuel Hässig (@mhaessig - Committer)
• Hamlin Li (@Hamlin-Li - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27414/head:pull/27414
$ git checkout pull/27414

Update a local copy of the PR:
$ git checkout pull/27414
$ git pull https://git.openjdk.org/jdk.git pull/27414/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27414

View PR using the GUI difftool:
$ git pr show -t 27414

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27414.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368206: RISC-V: compiler/vectorapi/VectorMaskCompareNotTest.java fails when running without RVV

Reviewed-by: fyang, mhaessig, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 88 new commits pushed to the master branch:

• 44cb9ca: 8368518: [s390x] test failure with failed: wrong size of mach node
• 4f4030a: 8333526: Restructure java/nio/channels/DatagramChannel/StressNativeSignal.java to a fail fast exception handling policy
• d85e410: 8368546: java/net/httpclient/RedirectTimeoutTest.java fails intermittently for HTTP/3 in tier7
• ... and 85 more: https://git.openjdk.org/jdk/compare/e6f8450d957f79beacf2fc70e545db3a4bb58742...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @mhaessig, @Hamlin-Li) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@DingliZhang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (983ddefc)

[RealFYang]

LGTM.

[Hamlin-Li]

Hey, I'm wondering if all the tests under hotspot/jtreg/compiler/vectorapi should @require rvv?
Otherwise seems they are not really testing anything useful?

[DingliZhang]

Hey, I'm wondering if all the tests under hotspot/jtreg/compiler/vectorapi should @require rvv? Otherwise seems they are not really testing anything useful?

@Hamlin-Li Good question! I think almost all IR related tests need RVV. Some non-IR tests can use scalars to implement vectorapi, such as compiler/vectorapi/TestVectorShuffleIotaByte.java, which also passes on sg2042 (without RVV).

[mhaessig]

Thank you for fixing this, @DingliZhang. Your change looks good, but let me just kick off some testing on our side to ensure the test still runs on other platforms. I'll get back to you as soon as the results are in.

[mhaessig]

Testing passed.

[DingliZhang]

Hey, I'm wondering if all the tests under hotspot/jtreg/compiler/vectorapi should @require rvv? Otherwise seems they are not really testing anything useful?

@Hamlin-Li Sorry, I think I misunderstood you earlier.
Currently, this is the only test case under hotspot/jtreg/compiler/vectorapi that fails without RVV, so I plan to merge this PR first and then open a separate issue JDK-8368602 to discuss the situation you mentioned.
Does that work for you ?

[Hamlin-Li]

@DingliZhang Thank you. The current PR looks good.

Not sure what to do with other vectorapi tests, but it's good to have a look if you got time. Thanks!

[DingliZhang]

Thanks all for the review!
/integrate

[openjdk]

@DingliZhang
Your change (at version 983ddef) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 67cb53d.
Since your change was applied there have been 88 commits pushed to the master branch:

• 44cb9ca: 8368518: [s390x] test failure with failed: wrong size of mach node
• 4f4030a: 8333526: Restructure java/nio/channels/DatagramChannel/StressNativeSignal.java to a fail fast exception handling policy
• d85e410: 8368546: java/net/httpclient/RedirectTimeoutTest.java fails intermittently for HTTP/3 in tier7
• ... and 85 more: https://git.openjdk.org/jdk/compare/e6f8450d957f79beacf2fc70e545db3a4bb58742...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @DingliZhang Pushed as commit 67cb53d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.