Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260923: Add more tests for SSLSocket input/output shutdown #2745

Closed
wants to merge 2 commits into from
Closed

8260923: Add more tests for SSLSocket input/output shutdown #2745

wants to merge 2 commits into from

Conversation

akolarkunnu
Copy link
Contributor

@akolarkunnu akolarkunnu commented Feb 26, 2021

There is a lack of tests in the area of java.net.Socket.shutdownInput() and java.net.Socket.shutdownOutput() , so added more tests in this area of with different TLS versions. Please review.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260923: Add more tests for SSLSocket input/output shutdown

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2745/head:pull/2745
$ git checkout pull/2745

Update a local copy of the PR:
$ git checkout pull/2745
$ git pull https://git.openjdk.java.net/jdk pull/2745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2745

View PR using the GUI difftool:
$ git pr show -t 2745

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2745.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 26, 2021

👋 Welcome back akolarkunnu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 26, 2021

@akolarkunnu The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Feb 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 26, 2021

@akolarkunnu
Reviewer coffeys successfully credited.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 26, 2021

Webrevs

@akolarkunnu
Copy link
Contributor Author

@akolarkunnu akolarkunnu commented Mar 2, 2021

/reviewer remove @coffeys

@akolarkunnu
Copy link
Contributor Author

@akolarkunnu akolarkunnu commented Mar 2, 2021

@coffeys

@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

@akolarkunnu
Reviewer coffeys successfully removed.

@coffeys
Copy link
Contributor

@coffeys coffeys commented Apr 9, 2021

Thanks for increasing code coverage here. Looks fine to me.

coffeys
coffeys approved these changes Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@akolarkunnu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260923: Add more tests for SSLSocket input/output shutdown

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 911 new commits pushed to the master branch:

  • b3782ea: 8264918: [JVMCI] getVtableIndexForInterfaceMethod doesn't check that type and method are related
  • f7a6c63: 8259822: [PPC64] Support the prefixed instruction format added in POWER10
  • a45733f: 8264779: Fix doclint warnings in java/nio
  • 3e57924: 8264885: Fix the code style of macro in aarch64_neon_ad.m4
  • 051c117: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo
  • 1c6b113: 8264513: Cleanup CardTableBarrierSetC2::post_barrier
  • 666fd62: 8264881: Remove the old development option MemProfiling
  • 951f277: 8264874: Build interim-langtools for HotSpot only if Graal is enabled
  • 719f95e: 8260693: Provide the support for specifying a signer in keytool -genkeypair
  • 77b1673: 8256245: AArch64: Implement Base64 decoding intrinsic
  • ... and 901 more: https://git.openjdk.java.net/jdk/compare/b0ee7a8624c42ca34d21e28bc23f208199a8eb4b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 9, 2021
@akolarkunnu
Copy link
Contributor Author

@akolarkunnu akolarkunnu commented Apr 9, 2021

/integrate

@openjdk openjdk bot closed this Apr 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@akolarkunnu Since your change was applied there have been 912 commits pushed to the master branch:

  • 33fa855: 8264732: Clean up LinkResolver::vtable_index_of_interface_method()
  • b3782ea: 8264918: [JVMCI] getVtableIndexForInterfaceMethod doesn't check that type and method are related
  • f7a6c63: 8259822: [PPC64] Support the prefixed instruction format added in POWER10
  • a45733f: 8264779: Fix doclint warnings in java/nio
  • 3e57924: 8264885: Fix the code style of macro in aarch64_neon_ad.m4
  • 051c117: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo
  • 1c6b113: 8264513: Cleanup CardTableBarrierSetC2::post_barrier
  • 666fd62: 8264881: Remove the old development option MemProfiling
  • 951f277: 8264874: Build interim-langtools for HotSpot only if Graal is enabled
  • 719f95e: 8260693: Provide the support for specifying a signer in keytool -genkeypair
  • ... and 902 more: https://git.openjdk.java.net/jdk/compare/b0ee7a8624c42ca34d21e28bc23f208199a8eb4b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9bb1863.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants