New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8260923: Add more tests for SSLSocket input/output shutdown #2745
Conversation
|
@akolarkunnu The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@akolarkunnu |
Webrevs
|
/reviewer remove @coffeys |
@akolarkunnu |
Thanks for increasing code coverage here. Looks fine to me. |
@akolarkunnu This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 911 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@akolarkunnu Since your change was applied there have been 912 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9bb1863. |
There is a lack of tests in the area of java.net.Socket.shutdownInput() and java.net.Socket.shutdownOutput() , so added more tests in this area of with different TLS versions. Please review.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2745/head:pull/2745
$ git checkout pull/2745
Update a local copy of the PR:
$ git checkout pull/2745
$ git pull https://git.openjdk.java.net/jdk pull/2745/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2745
View PR using the GUI difftool:
$ git pr show -t 2745
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2745.diff