-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8367910: Reduce warnings about unsupported classes in AOT cache creation #27480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8367910: Reduce warnings about unsupported classes in AOT cache creation #27480
Conversation
|
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
|
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
Thanks
vnkozlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
Thanks @dholmes-ora @vnkozlov @shipilev for the review |
|
Going to push as commit 52e7778.
Your commit was automatically rebased without conflicts. |
Currently AOT cache creation may print lots of warning (depending on the actions performed by the application's training run). Most of these warnings are harmless and are caused by JVM limitations; there's nothing that the user can do about them:
This PR moves most of these warnings to the "info" level. The only messages that are still logged in the "warning" levels are:
These could indicate issues with the application so it's good to let the user know.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27480/head:pull/27480$ git checkout pull/27480Update a local copy of the PR:
$ git checkout pull/27480$ git pull https://git.openjdk.org/jdk.git pull/27480/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27480View PR using the GUI difftool:
$ git pr show -t 27480Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27480.diff
Using Webrev
Link to Webrev Comment