Skip to content

Conversation

@iklam
Copy link
Member

@iklam iklam commented Sep 24, 2025

Currently AOT cache creation may print lots of warning (depending on the actions performed by the application's training run). Most of these warnings are harmless and are caused by JVM limitations; there's nothing that the user can do about them:

[1.096s][warning][aot] Skipping jdk/internal/event/Event: JFR event class
[1.096s][warning][aot] Skipping jdk/jfr/Event: JFR event class
[1.099s][warning][aot] Skipping jdk/proxy1/$Proxy14: Unsupported location
[1.100s][warning][aot] Skipping jdk/proxy1/$Proxy12: Unsupported location
[1.100s][warning][aot] Skipping jdk/proxy1/$Proxy11: Unsupported location

This PR moves most of these warnings to the "info" level. The only messages that are still logged in the "warning" levels are:

  • class is in an error state
  • class failed verification

These could indicate issues with the application so it's good to let the user know.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367910: Reduce warnings about unsupported classes in AOT cache creation (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27480/head:pull/27480
$ git checkout pull/27480

Update a local copy of the PR:
$ git checkout pull/27480
$ git pull https://git.openjdk.org/jdk.git pull/27480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27480

View PR using the GUI difftool:
$ git pr show -t 27480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27480.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2025

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367910: Reduce warnings about unsupported classes in AOT cache creation

Reviewed-by: dholmes, kvn, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 24, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2025

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2025
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iklam
Copy link
Member Author

iklam commented Sep 25, 2025

Thanks @dholmes-ora @vnkozlov @shipilev for the review
/integrate

@openjdk
Copy link

openjdk bot commented Sep 25, 2025

Going to push as commit 52e7778.
Since your change was applied there have been 52 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2025
@openjdk openjdk bot closed this Sep 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@iklam Pushed as commit 52e7778.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants