8357691: File blocked.certs contains bad content when boot jdk 25 is used, sun/security/lib/CheckBlockedCerts.java failing#27485
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/label security |
|
@rhalade |
|
The fix looks OK to me. Background: when using the default CDS archive, such warnings are disabled. The reason is -- we assume the default archive is general purpose and can be used for different sets of command-lines. We don't print warnings as it's not "wrong" for the app to specify But when you are using In this case, I think the JDK build system creates its own CDS archive with the BOOT JDK, so it falls under the second scenario. Using |
|
Hi Ioi , thanks for the detailed explanation, why this happens. And thanks for the reviews ! /integrate |
|
Going to push as commit a80ba62.
Your commit was automatically rebased without conflicts. |
When using boot JDK 25 we end up with bad content in lib/security/blocked.certs because cds related warning output shows up there.
The problem is with extra lines in the generated
blocked.certsfile, at the start of the file there is something like thisProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27485/head:pull/27485$ git checkout pull/27485Update a local copy of the PR:
$ git checkout pull/27485$ git pull https://git.openjdk.org/jdk.git pull/27485/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27485View PR using the GUI difftool:
$ git pr show -t 27485Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27485.diff
Using Webrev
Link to Webrev Comment