8368694: PKCS11-NSS generic keys generated by DH have leading zeroes stripped

[djelinski]

The DiffieHellman KeyAgreement supports 2 key algorithms: TlsPremasterSecret and Generic. The Generic algorithm is supposed to generate keys of a constant length, keeping leading zeroes as appropriate.

This PR changes the SunPKCS11 implementation to pass a CKA_VALUE_LEN attribute when a fixed length is needed; when the attribute is absent, the PKCS11 provider strips the leading zeroes.

Added a check to the existing test cases to verify the fix. The check passes with the fix, fails without it. Other tier1-3 tests continue to pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368694: PKCS11-NSS generic keys generated by DH have leading zeroes stripped (Bug - P4)

Reviewers

• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27494/head:pull/27494
$ git checkout pull/27494

Update a local copy of the PR:
$ git checkout pull/27494
$ git pull https://git.openjdk.org/jdk.git pull/27494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27494

View PR using the GUI difftool:
$ git pr show -t 27494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27494.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368694: PKCS11-NSS generic keys generated by DH have leading zeroes stripped

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 206 new commits pushed to the master branch:

• 79bcc7b: 8369257: PPC: compiler/whitebox/RelocateNMethodMultiplePaths.java fails with assertion
• 927aa3f: 8369178: G1: Use NMethodMarkingScope and ThreadsClaimTokenScope in G1RootProcessor
• 23fcbb0: 8365153: AArch64: Set JVM flags for Neoverse N3 and V3 cores
• ... and 203 more: https://git.openjdk.org/jdk/compare/3183a13f666ff38c03c0628e139998803be8a719...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (818e0348)
• 00: Full (7f1e31bf)

[valeriepeng]

How about attributes in another xxxGenerateSecret(...) method? Should we also add CKA_VALUE_LEN attribute with secretLen value there as well, i.e. line 200-203,

[djelinski]

Thanks @valeriepeng for the review. I added CKA_VALUE_LEN to the paramterless overload now.

[valeriepeng]

Changes look good.

[djelinski]

Thanks @valeriepeng for the re-review.

/integrate

[openjdk]

Going to push as commit 914b44e.
Since your change was applied there have been 213 commits pushed to the master branch:

• 0b81db1: 8364346: Typo in IR framework README
• 5873c4b: 8369039: JDK-8348611 caused regression in Javac-Hot-Generate
• 0e5655e: 8367657: C2 SuperWord: NormalMapping demo from JVMLS 2025
• ... and 210 more: https://git.openjdk.org/jdk/compare/3183a13f666ff38c03c0628e139998803be8a719...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit 914b44e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.