Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8262471: Fix coding style in src/java.base/share/classes/java/lang/CharacterDataPrivateUse.java #2754

Closed
wants to merge 1 commit into from

Conversation

mychris
Copy link
Member

@mychris mychris commented Feb 26, 2021

Please review this small patch which fixes the coding style of CharacterDataPrivateUse.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262471: Fix coding style in src/java.base/share/classes/java/lang/CharacterDataPrivateUse.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2754/head:pull/2754
$ git checkout pull/2754

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2021

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 26, 2021

@mychris The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Feb 26, 2021
@mychris mychris changed the title Fixes coding style. JDK-8262471: Fix coding style in src/java.base/share/classes/java/lang/CharacterDataPrivateUse.java Feb 26, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 26, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 26, 2021

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Looks fine. This source file was a .template until a few weeks ago, probably should have fixed the indentation issues when moving it to a .java file.

@openjdk
Copy link

openjdk bot commented Feb 27, 2021

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262471: Fix coding style in src/java.base/share/classes/java/lang/CharacterDataPrivateUse.java

Reviewed-by: alanb, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 138 new commits pushed to the master branch:

  • 4d21a45: 8262913: KlassFactory::create_from_stream should never return NULL
  • fab5676: 8247869: Change NONCOPYABLE to delete the operations
  • c0542ed: 6251901: BasicTextUI: installDefaults method are contrary to the documentation
  • fdd3941: 8263233: Update java.net and java.nio to use instanceof pattern variable
  • 3fe8a46: 8263170: ComboBoxModel documentation refers to a nonexistent type
  • d8a9c3c: 8263002: Remove CDS MiscCode region
  • 67ea3bd: 8263102: Expand documention of Method.isBridge
  • d0c1aec: 8263140: Japanese chars garble in console window in HSDB
  • 70342e8: 8262520: Add SA Command Line Debugger support to connect to debug server
  • e5ce97b: 8263206: assert(*error_msg != '\0') failed: Must have error_message while parsing -XX:CompileCommand=unknown
  • ... and 128 more: https://git.openjdk.java.net/jdk/compare/a4c249610e7c0fcc7fd863f14f51c96abc5ca39f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 27, 2021
@mychris
Copy link
Member Author

mychris commented Mar 1, 2021

Thanks for the review.
Do we need a second reviewer? If not, could you please sponsor the change?
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 1, 2021
@openjdk
Copy link

openjdk bot commented Mar 1, 2021

@mychris
Your change (at version 4e0f150) is now ready to be sponsored by a Committer.

@mychris
Copy link
Member Author

mychris commented Mar 10, 2021

Could a second reviewer please look at this tiny, whitespace only change and sponsor it?

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

For (most) core-libs changes, only 1 reviewer is required.
However, given the broad interest, please allow time (a day or weekend) for others to take a look.

@RogerRiggs
Copy link
Contributor

RogerRiggs commented Mar 10, 2021

/sponsor

@openjdk openjdk bot closed this Mar 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2021
@openjdk
Copy link

openjdk bot commented Mar 10, 2021

@RogerRiggs @mychris Since your change was applied there have been 138 commits pushed to the master branch:

  • 4d21a45: 8262913: KlassFactory::create_from_stream should never return NULL
  • fab5676: 8247869: Change NONCOPYABLE to delete the operations
  • c0542ed: 6251901: BasicTextUI: installDefaults method are contrary to the documentation
  • fdd3941: 8263233: Update java.net and java.nio to use instanceof pattern variable
  • 3fe8a46: 8263170: ComboBoxModel documentation refers to a nonexistent type
  • d8a9c3c: 8263002: Remove CDS MiscCode region
  • 67ea3bd: 8263102: Expand documention of Method.isBridge
  • d0c1aec: 8263140: Japanese chars garble in console window in HSDB
  • 70342e8: 8262520: Add SA Command Line Debugger support to connect to debug server
  • e5ce97b: 8263206: assert(*error_msg != '\0') failed: Must have error_message while parsing -XX:CompileCommand=unknown
  • ... and 128 more: https://git.openjdk.java.net/jdk/compare/a4c249610e7c0fcc7fd863f14f51c96abc5ca39f...master

Your commit was automatically rebased without conflicts.

Pushed as commit c8c0234.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
3 participants