Skip to content

8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs#27629

Closed
dcubed-ojdk wants to merge 3 commits intoopenjdk:masterfrom
dcubed-ojdk:JDK-8367302
Closed

8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs#27629
dcubed-ojdk wants to merge 3 commits intoopenjdk:masterfrom
dcubed-ojdk:JDK-8367302

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 3, 2025

In order to reduce noise in the JDK26 CI, I'm bundling the following three trivial fixes:

JDK-8369128 ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs

JDK-8369132 Disable vmTestbase/gc/vector/CircularListLow and LinearListLow with SerialGC

JDK-8369133 Disable gc/g1/TestShrinkAuxiliaryDataRunner.java with UseLargePages option


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs (Sub-task - P4)
  • JDK-8369132: Disable vmTestbase/gc/vector/CircularListLow and LinearListLow with SerialGC (Sub-task - P3)
  • JDK-8369133: Disable gc/g1/TestShrinkAuxiliaryDataRunner.java with UseLargePages option (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27629/head:pull/27629
$ git checkout pull/27629

Update a local copy of the PR:
$ git checkout pull/27629
$ git pull https://git.openjdk.org/jdk.git pull/27629/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27629

View PR using the GUI difftool:
$ git pr show -t 27629

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27629.diff

Using Webrev

Link to Webrev Comment

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-gc
/label add hotspot-jar

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review October 3, 2025 20:42
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2025

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk dcubed-ojdk changed the title ProblemListing 1 test and disabling 2 other tests ProblemListing 1 test and disabling 3 other tests Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs
8369132: Disable vmTestbase/gc/vector/CircularListLow and LinearListLow with SerialGC
8369133: Disable gc/g1/TestShrinkAuxiliaryDataRunner.java with UseLargePages option

Reviewed-by: ayang, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk
The hotspot-gc label was successfully added.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk
The label hotspot-jar is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Oct 3, 2025

/label add hotspot-jfr

Blasted auto-correct keeps changing what I type...

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk
The hotspot-jfr label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8369128
/issue JDK-8369132
/issue JDK-8369133

@openjdk openjdk bot changed the title ProblemListing 1 test and disabling 3 other tests 8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk
Adding additional issue to issue list: 8369132: Disable vmTestbase/gc/vector/CircularListLow and LinearListLow with SerialGC.

@dcubed-ojdk
Copy link
Member Author

It's been too long since I've bundled multiple fixes together. I forgot a couple of steps...

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk
Adding additional issue to issue list: 8369133: Disable gc/g1/TestShrinkAuxiliaryDataRunner.java with UseLargePages option.

@dcubed-ojdk
Copy link
Member Author

@albertnetymk - Thanks for the review!

@dcubed-ojdk
Copy link
Member Author

All Mach5 testing that I've done is documented in each bug report.

@mlbridge
Copy link

mlbridge bot commented Oct 3, 2025

Webrevs

@dcubed-ojdk
Copy link
Member Author

/integrate

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

I approved the fix for jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java a couple of days ago but for some reason the author has not been around to integrate it. I have made a note on the PR that now they will need to fix the PL too.

Thanks

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

Going to push as commit 837f634.
Since your change was applied there have been 4 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2025
@openjdk openjdk bot closed this Oct 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@dcubed-ojdk Pushed as commit 837f634.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants