8262500: HostName entry in VM.info should be a new line

[YaSuenag]

We can get host name from VM.info dcmd (and also hs_err log) on fastdebug build as below. It affects (fast)debug build for Windows only.

--------------- S Y S T E M ---------------

HostName: Xelvis OS:
 Windows 10 , 64 bit Build 19041 (10.0.19041.804)
OS uptime: 1 days 1:33 hours
Hyper-V role detected

OS label is available within HostName entry. It should be in a new line.

After this change, we can get VM.info output as below:

---------------  S Y S T E M  ---------------

HostName: Xelvis
OS:
 Windows 10 , 64 bit Build 19041 (10.0.19041.804)
OS uptime: 1 days 1:44 hours
Hyper-V role detected

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8262500: HostName entry in VM.info should be a new line

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2763/head:pull/2763
$ git checkout pull/2763

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (75d940b)

[tstuefe]

Looks fine to me. I was surprised to see that we print out hostnames only in debug versions until I realized that this may be a security feature.

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262500: HostName entry in VM.info should be a new line

Reviewed-by: stuefe, dcubed, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[YaSuenag]

Thanks @tstuefe !

I was surprised to see that we print out hostnames only in debug versions until I realized that this may be a security feature.

Comment in JDK-8056930 says the reason why hostname is available in debug build only. I agree with that mostly, but TransmitErrorReport has been obsoleted by the JDK-8209856.

[dcubed-ojdk]

Why is the "OS:" label not on the same line as the OS information?
(Existing bug, but I'm curious.)

Something like this:

OS: Windows 10 , 64 bit Build 19041 (10.0.19041.804)

[YaSuenag]

Thanks @dcubed-ojdk !

Why is the "OS:" label not on the same line as the OS information?
(Existing bug, but I'm curious.)

Something like this:

OS: Windows 10 , 64 bit Build 19041 (10.0.19041.804)

I don't know the reason, but I agree with you OS label and information should be in same line.
May I file it to JBS and fix?

[dcubed-ojdk]

Sure. Fixing it as a separate issue would be cleaner.

[YaSuenag]

@dcubed-ojdk I added it as JDK-8262507 and sent PR #2770.

[dholmes-ora]

Looks fine.

Thanks,
David

[YaSuenag]

/integrate

[openjdk]

@YaSuenag Since your change was applied there have been 15 commits pushed to the master branch:

• 9f0f0c9: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings
• d339832: 8257414: Drag n Drop target area is wrong on high DPI systems
• 353416f: 8262509: JSSE Server should check the legacy version in TLSv1.3 ClientHello
• 642f45f: 8261839: Error creating runtime package on macos without mac-package-identifier
• 682e120: 8262497: Delete unused utility methods in ICC_Profile class
• 4c9adce: 8262379: Add regression test for JDK-8257746
• 6baecf3: 8259937: guarantee(loc != NULL) failed: missing saved register with native invoker
• c569f1d: 8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux
• 75bf106: 8262028: Make InstanceKlass::implementor return InstanceKlass
• fe8e370: 8262188: Add test to verify trace page sizes logging on Linux
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/03d888f463c0a6e3fee70ed8ad606fc0a3082636...master

Your commit was automatically rebased without conflicts.

Pushed as commit c3eb80e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.