8245234: Still seeing missing mixed stack traces, even after JDK-8234624

[YaSuenag]

We haven't yet been able to unwind native frames in mixed mode jhsdb in some case even though we implement DWARF parser in JDK-8234624. The cause is that DwarfParser would be reused.

DWARF is encoded as a state machine, so we have to initialize when we try to find new frame via DWARF. So I made change to create new DwarfParser instance everytime in LinuxAMD64CFrame::sender.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8245234: Still seeing missing mixed stack traces, even after JDK-8234624 (Bug - P3)

Reviewers

• Kevin Walls (@kevinjwalls - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27636/head:pull/27636
$ git checkout pull/27636

Update a local copy of the PR:
$ git checkout pull/27636
$ git pull https://git.openjdk.org/jdk.git pull/27636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27636

View PR using the GUI difftool:
$ git pr show -t 27636

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27636.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245234: Still seeing missing mixed stack traces, even after JDK-8234624

Reviewed-by: kevinw, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 2376a9e: 8365630: jdk/jfr/tool/TestPrintContextual.java fails with wrong spanId
• 0f406c4: 8369078: Fix faulty test conversion in IllegalCharsetName.java
• 596af0a: 8369041: Release memory after testing in ThreadsRunner.java
• ... and 11 more: https://git.openjdk.org/jdk/compare/f740cd2aad43a008da1ed1ff15ebe2c790f893a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bf91a611)

[kevinjwalls]

I think this looks good, makes sense, the native DwarfParser has its own context. So the existing reuse of dwarf as nextDwarf at old line 150 might be unwise!

I see that getNextCFA, called down at new line 168, handles nextDwarf being null.

[plummercj]

Looks good!

[YaSuenag]

Thanks both for reviewing!

/integrate

[openjdk]

Going to push as commit 9c46feb.
Since your change was applied there have been 20 commits pushed to the master branch:

• 6bec42a: 8368892: Make JEditorPane/TestBrowserBGColor.java headless
• aed9485: 8368303: AlwaysAtomicAccesses is excessively strict
• c06d680: 8362394: C2: Repeated stacked string concatenation fails with "Hit MemLimit" and other resourcing errors
• ... and 17 more: https://git.openjdk.org/jdk/compare/f740cd2aad43a008da1ed1ff15ebe2c790f893a0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@YaSuenag Pushed as commit 9c46feb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.