Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262503: Support records in Dynalink #2767

Closed
wants to merge 3 commits into from

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Feb 28, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2767/head:pull/2767
$ git checkout pull/2767

Update a local copy of the PR:
$ git checkout pull/2767
$ git pull https://git.openjdk.java.net/jdk pull/2767/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2767

View PR using the GUI difftool:
$ git pr show -t 2767

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2767.diff

@szegedi
Copy link
Contributor Author

szegedi commented Feb 28, 2021

/csr needed

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2021

👋 Welcome back attila! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Feb 28, 2021
@openjdk
Copy link

openjdk bot commented Feb 28, 2021

@szegedi has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@szegedi please create a CSR request and add link to it in JDK-8262503. This pull request cannot be integrated until the CSR request is approved.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2021
@openjdk
Copy link

openjdk bot commented Feb 28, 2021

@szegedi To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@szegedi
Copy link
Contributor Author

szegedi commented Mar 1, 2021

/label core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 1, 2021
@openjdk
Copy link

openjdk bot commented Mar 1, 2021

@szegedi
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 1, 2021

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Mar 22, 2021
Copy link
Member

@sundararajana sundararajana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@szegedi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262503: Support records in Dynalink

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 453 new commits pushed to the master branch:

  • af02883: 8264191: Javadoc search is broken in Internet Explorer
  • 6e74c3a: 8264193: Remove TRAPS parameters for modules and defaultmethods
  • ee5e00b: 8264279: Shenandoah: Missing handshake after JDK-8263427
  • ac604a1: 8264374: Shenandoah: Remove leftover parallel reference processing argument
  • f3726a8: 8264020: Optimize double negation elimination
  • 4ffa41c: 8263615: Cleanup tightly_coupled_allocation
  • 4ea6abf: 8264324: Simplify allocation list management in OopStorage::reduce_deferred_updates
  • 8735259: 8264333: Use the blessed modifier order in jdk.jshell
  • d2a63f2: 8264360: Loop strip mining verification fails with "should be on the backedge"
  • 8100a20: 8263971: C2 crashes with SIGFPE with -XX:+StressGCM and -XX:+StressIGVN
  • ... and 443 more: https://git.openjdk.java.net/jdk/compare/03d888f463c0a6e3fee70ed8ad606fc0a3082636...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2021
@szegedi
Copy link
Contributor Author

szegedi commented Mar 30, 2021

/integrate

@szegedi
Copy link
Contributor Author

szegedi commented Mar 30, 2021

Thank you for the review, @sundararajana!

@openjdk openjdk bot closed this Mar 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2021
@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@szegedi Since your change was applied there have been 458 commits pushed to the master branch:

  • 21e7402: 8263707: C1 RangeCheckEliminator support constant array and NewMultiArray
  • 2ad6f2d: 8263896: Make not_suspended parameter from ObjectMonitor::exit() have default value
  • b652198: 8264429: Test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build
  • 2c9365d: 8264271: Avoid creating non_oop_word oops
  • daeca3f: 8262958: (fs) UnixUserDefinedFileAttributeView cleanup
  • af02883: 8264191: Javadoc search is broken in Internet Explorer
  • 6e74c3a: 8264193: Remove TRAPS parameters for modules and defaultmethods
  • ee5e00b: 8264279: Shenandoah: Missing handshake after JDK-8263427
  • ac604a1: 8264374: Shenandoah: Remove leftover parallel reference processing argument
  • f3726a8: 8264020: Optimize double negation elimination
  • ... and 448 more: https://git.openjdk.java.net/jdk/compare/03d888f463c0a6e3fee70ed8ad606fc0a3082636...master

Your commit was automatically rebased without conflicts.

Pushed as commit b08d638.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@szegedi szegedi deleted the dynalink-records branch March 30, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants