8253392: remove PhaseCCP_DCE declaration

[navyxliu]

hello, reviewers,
May I ask to review this trivial patch?
it's a clean-up. The forward declaration of PhaseCCP_DCE is not useful.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253392: remove PhaseCCP_DCE declaration

Reviewers

• Nils Eliasson (@neliasso - Reviewer)
• Paul Hohensee (@phohensee - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/277/head:pull/277
$ git checkout pull/277

[bridgekeeper]

Hi @navyxliu, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user navyxliu" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@navyxliu The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 00: Full (15bdfbf)

[openjdk]

@navyxliu This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253392: remove PhaseCCP_DCE declaration

remove the deprecated declaration PhaseCCP_DCE

Reviewed-by: neliasso, phh

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 30 commits pushed to the master branch:

• 65af837: 8253496: [BACKOUT] JDK-8253208 Move CDS related code to a separate class
• 581f0f2: 8253493: Shenandoah: Remove ShenandoahSerialRoot definition
• 7b86012: 8253492: Miss comma after second copyright year in FDBigInteger.java
• 0f26ab1: 8252518: cache result of CompilerToVM.getComponentType
• c1df13b: 8253208: Move CDS related code to a separate class
• 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…
• 3d5fea1: 8253434: Shenandoah: Cleanup ShenandoahRootScanner
• 8c02bdb: 8252921: NMT overwrite memory type for region assert when building dynamic archive
• 0c287de: 8253421: Initialize JFR trace-IDs with zero
• aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
• ... and 20 more: https://git.openjdk.java.net/jdk/compare/34ec1bedd1c2d774c52f3664f9b57a4422877bfe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 65af837391410bc5803cb570235d6a5fb70760bb.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@neliasso, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Mailing list message from Liu, Xin on hotspot-compiler-dev:

Thanks, Nils!

First time to try Skara CLI, so far so good!
The only problem is I forgot to config user.name in my git. My name is 'ubuntu' this time.
fixed. I will use my name in next PR.

if it looks good, please help me to 'integrate' this PR.
thanks,
--lx

________________________________________
From: hotspot-compiler-dev <hotspot-compiler-dev-retn at openjdk.java.net> on behalf of Nils Eliasson <neliasso at openjdk.java.net>
Sent: Monday, September 21, 2020 2:45 AM
To: hotspot-compiler-dev at openjdk.java.net
Subject: RE: [EXTERNAL] RFR: 8253392: remove PhaseCCP_DCE declaration

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

On Mon, 21 Sep 2020 08:01:27 GMT, Xin Liu <xliu at openjdk.org> wrote:

hello, reviewers,
May I ask to review this trivial patch?
it's a clean-up. The forward declaration of PhaseCCP_DCE is not useful.

Marked as reviewed by neliasso (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/277

[navyxliu]

/covered

[bridgekeeper]

You are already a known contributor!

[navyxliu]

/summary remove the deprecated declaration PhaseCCP_DCE

[openjdk]

@navyxliu Setting summary to remove the deprecated declaration PhaseCCP_DCE

[phohensee]

Lgtm.

[navyxliu]

/reviewer credit phohensee

[navyxliu]

/reviewer credit neliasso

[openjdk]

@navyxliu Could not parse phohensee as a valid reviewer.
Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

• /reviewer credit @openjdk-bot
• /reviewer credit duke
• /reviewer credit @user1 @user2

[openjdk]

@navyxliu Reviewer neliasso has already made an authenticated review of this PR, and does not need to be credited manually.

[navyxliu]

/integrate

[openjdk]

@navyxliu
Your change (at version 15bdfbf) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

@phohensee @navyxliu Since your change was applied there have been 30 commits pushed to the master branch:

• 65af837: 8253496: [BACKOUT] JDK-8253208 Move CDS related code to a separate class
• 581f0f2: 8253493: Shenandoah: Remove ShenandoahSerialRoot definition
• 7b86012: 8253492: Miss comma after second copyright year in FDBigInteger.java
• 0f26ab1: 8252518: cache result of CompilerToVM.getComponentType
• c1df13b: 8253208: Move CDS related code to a separate class
• 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…
• 3d5fea1: 8253434: Shenandoah: Cleanup ShenandoahRootScanner
• 8c02bdb: 8252921: NMT overwrite memory type for region assert when building dynamic archive
• 0c287de: 8253421: Initialize JFR trace-IDs with zero
• aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
• ... and 20 more: https://git.openjdk.java.net/jdk/compare/34ec1bedd1c2d774c52f3664f9b57a4422877bfe...master

Your commit was automatically rebased without conflicts.

Pushed as commit 426c904.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.