Skip to content

8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler#27757

Closed
feilongjiang wants to merge 2 commits intoopenjdk:masterfrom
feilongjiang:riscv-remove-unnecessary-barriers
Closed

8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler#27757
feilongjiang wants to merge 2 commits intoopenjdk:masterfrom
feilongjiang:riscv-remove-unnecessary-barriers

Conversation

@feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Oct 11, 2025

Same as JDK-8369190, but for the RISC-V port.

Testing:

  • tier1-3

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27757/head:pull/27757
$ git checkout pull/27757

Update a local copy of the PR:
$ git checkout pull/27757
$ git pull https://git.openjdk.org/jdk.git pull/27757/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27757

View PR using the GUI difftool:
$ git pr show -t 27757

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27757.diff

Using Webrev

Link to Webrev Comment

@feilongjiang feilongjiang changed the title 8369616: JavaFrameAnchor on RISCV has unnecessary barriers and wrong store order in MacroAssembler 8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler Oct 11, 2025
@feilongjiang feilongjiang marked this pull request as draft October 11, 2025 12:49
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2025

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 11, 2025

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 11, 2025
@openjdk
Copy link

openjdk bot commented Oct 11, 2025

@feilongjiang The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@feilongjiang feilongjiang marked this pull request as ready for review October 13, 2025 01:25
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2025

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 13, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2025
@feilongjiang
Copy link
Member Author

feilongjiang commented Oct 14, 2025

@luhenry @RealFYang Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2025

Going to push as commit 7266369.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2025
@openjdk openjdk bot closed this Oct 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2025
@openjdk
Copy link

openjdk bot commented Oct 14, 2025

@feilongjiang Pushed as commit 7266369.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang
Copy link
Member Author

/backport jdk25u

@openjdk
Copy link

openjdk bot commented Oct 14, 2025

@feilongjiang the backport was successfully created on the branch backport-feilongjiang-72663695-master in my personal fork of openjdk/jdk25u. To create a pull request with this backport targeting openjdk/jdk25u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 72663695 from the openjdk/jdk repository.

The commit being backported was authored by Feilong Jiang on 14 Oct 2025 and was reviewed by Fei Yang and Ludovic Henry.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u:

$ git fetch https://github.com/openjdk-bots/jdk25u.git backport-feilongjiang-72663695-master:backport-feilongjiang-72663695-master
$ git checkout backport-feilongjiang-72663695-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk25u.git backport-feilongjiang-72663695-master

@feilongjiang
Copy link
Member Author

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Oct 19, 2025

@feilongjiang the backport was successfully created on the branch backport-feilongjiang-72663695-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 72663695 from the openjdk/jdk repository.

The commit being backported was authored by Feilong Jiang on 14 Oct 2025 and was reviewed by Fei Yang and Ludovic Henry.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-feilongjiang-72663695-master:backport-feilongjiang-72663695-master
$ git checkout backport-feilongjiang-72663695-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-feilongjiang-72663695-master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants