Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255859: Incorrect comments in log.hpp #2785

Closed

Conversation

@iklam
Copy link
Member

@iklam iklam commented Mar 2, 2021

Please review this trivial, comment-only change. I updated the comments to match the current usage for Log and LogTarget. I also tried to make the examples consistent so you can easily see the difference between Log and LogTarget.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2785/head:pull/2785
$ git checkout pull/2785

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 2, 2021

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

@iklam The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@iklam iklam marked this pull request as ready for review Mar 2, 2021
@openjdk openjdk bot added the rfr label Mar 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 2, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Looks good, and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255859: Incorrect comments in log.hpp

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d339832: 8257414: Drag n Drop target area is wrong on high DPI systems

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 2, 2021
@iklam
Copy link
Member Author

@iklam iklam commented Mar 2, 2021

Thanks @kimbarrett for the review.
/integrate

@openjdk openjdk bot closed this Mar 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

@iklam Since your change was applied there have been 3 commits pushed to the master branch:

  • c3eb80e: 8262500: HostName entry in VM.info should be a new line
  • 9f0f0c9: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings
  • d339832: 8257414: Drag n Drop target area is wrong on high DPI systems

Your commit was automatically rebased without conflicts.

Pushed as commit 85b774a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants