8241066: Shenandoah: fix or cleanup SH::do_full_collection

[earthling-amzn]

This ShenandoahHeap::do_full_collection will never be called by our implementation of collect_as_vm_thread.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8241066: Shenandoah: fix or cleanup SH::do_full_collection (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27853/head:pull/27853
$ git checkout pull/27853

Update a local copy of the PR:
$ git checkout pull/27853
$ git pull https://git.openjdk.org/jdk.git pull/27853/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27853

View PR using the GUI difftool:
$ git pr show -t 27853

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27853.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8241066: Shenandoah: fix or cleanup SH::do_full_collection

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• 0a97bef: 8369814: G1: Relax card mark and store ordering
• e62a7fa: 8342659: Test vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java failed: Class nsk.share.jdi.TestClass1 was not unloaded
• 9b9559a: 8369979: Flag UsePopCountInstruction was accidentally disabled on PPC64
• ... and 54 more: https://git.openjdk.org/jdk/compare/95def24b025341b5a6b99abdd4d1f3d26a40431c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6f660f80)

[earthling-amzn]

/integrate

[openjdk]

Going to push as commit f84be36.
Since your change was applied there have been 62 commits pushed to the master branch:

• 1e5e17a: 8369590: LocaleEnhanceTest has incorrectly passing test case
• 28bf917: 8348844: Remove remaining JVMTI tests from ProblemList-Virtual, use requires instead
• cc6f8f1: 8369997: Tests that use custom scheduler should use jdk.test.lib.thread.VThreadScheduler
• ... and 59 more: https://git.openjdk.org/jdk/compare/95def24b025341b5a6b99abdd4d1f3d26a40431c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@earthling-amzn Pushed as commit f84be36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.